SociopathicPixel commented on a change in pull request #230: dev/add datatypes
to excel columns
URL: https://github.com/apache/metamodel/pull/230#discussion_r334518831
##########
File path: core/src/main/java/org/apache/metamodel/DeleteAndInsertBuilder.java
##########
@@ -69,12 +69,33 @@ public void execute() throws MetaModelException {
private List<Row> updateRows(List<Row> rows) {
for (ListIterator<Row> it = rows.listIterator(); it.hasNext();) {
final Row original = (Row) it.next();
+ validateUpdateType(original);
Review comment:
removed it from the class with next commit, I think it was to prevent the
insertion of for example a String value into a Column which only contains
Integers and therefore has the columnType of Integer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
