SociopathicPixel commented on a change in pull request #230: dev/add datatypes
to excel columns
URL: https://github.com/apache/metamodel/pull/230#discussion_r334791157
##########
File path:
excel/src/main/java/org/apache/metamodel/excel/DefaultSpreadsheetReaderDelegate.java
##########
@@ -148,8 +151,16 @@ private MutableTable createTable(final Workbook wb, final
Sheet sheet) {
for (int j = offset; j < row.getLastCellNum(); j++) {
final ColumnNamingContext namingContext = new
ColumnNamingContextImpl(table, null, j);
- final Column column = new
MutableColumn(columnNamingSession.getNextColumnName(namingContext),
- ColumnType.STRING, table, j, true);
+ final Column column;
+ if (_configuration.isDetectColumnTypes()) {
Review comment:
you mean the whole part? (lines 146 - 166).
Also appearantly I'm not in beta mode on this repo which is a bummer for
selecting code in review comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
