SociopathicPixel commented on a change in pull request #230: dev/add datatypes 
to excel columns
URL: https://github.com/apache/metamodel/pull/230#discussion_r334523779
 
 

 ##########
 File path: 
excel/src/main/java/org/apache/metamodel/excel/ExcelInsertBuilder.java
 ##########
 @@ -149,8 +151,33 @@ protected CellStyle fetch() {
                                        cell.setCellStyle(cellStyle.get());
                                }
                        }
+                       validateUpdateType(row);
 
 Review comment:
   see: ExcelDataContextTest.testUpdateDifferentDataTypes
   
   It looks if the Column has a specific ColumnType and if so it will validate 
the given row.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to