Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/308#discussion_r83277025
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/GrokParser.java
---
@@ -150,8 +149,8 @@ public void init() {
if (message.size() == 0)
throw new RuntimeException("Grok statement produced a null
message. Original message was: "
- + originalMessage + " and the parsed message was: " +
message + " . Check the pattern at: "
- + grokPath);
+ + originalMessage + " , parsed message was: " + message +
" , pattern was: "
+ + grokPattern);
--- End diff --
Including several KB of grokPattern in the exception log might not be
necessary, especially since if DEBUG is turned on, it was already dumped to log
in line 106. Suggest the exception should log only patternLabel and
timestampField (or patternHash if you add one). This is comparable to the
former behavior of logging the path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
