Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/308#discussion_r83276073
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/GrokParser.java
---
@@ -132,8 +130,9 @@ public void init() {
@SuppressWarnings("unchecked")
@Override
- public List<JSONObject> parse(byte[] rawMessage) {
- if (grok == null) {
+ public List<JSONObject> parse(byte[] rawMessage, SensorParserConfig
sensorParserConfig) {
+ if (grok == null || isGrokPatternUpdated(sensorParserConfig) ||
isPatternLabelUpdated(sensorParserConfig)) {
+ configure(sensorParserConfig.getParserConfig());
--- End diff --
Is the pattern timestampField reliable? If so, comparing it would be much
cheaper than comparing the whole grokPattern, which can be long, and
additionally comparing the patternLabel would be unnecessary. If not, a SHA1
hash signature of the grokPattern+patternLabel could be added. This comparison
is being done on every message, so worth streamlining.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
