Github user nickwallen commented on a diff in the pull request:
@@ -34,15 +34,15 @@
* @param rawMessage
* @return If null is returned, this is treated as an empty list.
- List<T> parse(byte rawMessage);
+ List<T> parse(byte rawMessage, SensorParserConfig sensorParserConfig);
--- End diff --
I think our current approach to configuration has worked so far, but as
we've grown, it has caused some problems like tight coupling and limiting
@mattf-horton If you (or anyone else) have thoughts on an alternative
architectural approach for configuration, please share on the dev mailing list.
I think we need to do better there. The core problem to tackle with
configuration is that components need to be notified of changes made on-the-fly
and handle them seamlessly.
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket