Github user merrimanr commented on a diff in the pull request:
@@ -34,15 +34,15 @@
* @param rawMessage
* @return If null is returned, this is treated as an empty list.
- List<T> parse(byte rawMessage);
+ List<T> parse(byte rawMessage, SensorParserConfig sensorParserConfig);
--- End diff --
Before we go any further I think we need to decide if changing the
MessageParser interface is acceptable or not. If I remember correctly the
change to the interface is what prompted this whole conversation.
My opinion is that we quit worrying so much about the interface changing
and instead focus on getting it right. Thoughts?
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket