Github user cestella commented on a diff in the pull request:
    --- Diff: 
    @@ -34,15 +34,15 @@
        * @param rawMessage
        * @return If null is returned, this is treated as an empty list.
    -  List<T> parse(byte[] rawMessage);
    +  List<T> parse(byte[] rawMessage, SensorParserConfig sensorParserConfig);
    --- End diff --
    Now that I think about it, you could actually do the following:
    * Provide a `configurationChanged` method in `MessageParser` with a default 
noop implementation
    * Change the argument to `parseOptionally` to take a Config and in the 
default implementation of `parseOptionally` call `configurationChanged` upon 
configuration change.  
    This would leave `parse` alone and provide the capability to reconfigure on 
configuration changes seamlessly to parsers going forward.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to