tomaswolf commented on PR #77: URL: https://github.com/apache/mina/pull/77#issuecomment-6078221092
> And it occasionally will succeed. Yes, that's the problem with race conditions. I have no idea how we could provoke hitting it more frequently. > I'm assuming this is due to the fact ciphers differ between Java version. Do we want to find a cipher that works for all possible versions (possible?) or just those that are CI configured? As part of the release process we will run tests locally, and they must not fail. So yes, we have to find a way to make this work on CI and locally in different configurations. I see two ways: * check that the cipher is supported before trying to use, and use `assumeTrue(cipherIsSupported())`. Disadvantage: on a system where none of the test's ciphers are supported, all tests will be skipped. * or use a commonly supported cipher like TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
