elecharny commented on code in PR #77: URL: https://github.com/apache/mina/pull/77#discussion_r4231837573
########## mina-core/src/main/java/org/apache/mina/filter/ssl/SSLHandlerG1.java: ########## Review Comment: We should never have committed that 2 years ago... ;-) ########## mina-core/src/test/java/org/apache/mina/filter/ssl/SslEnd2EndTest.java: ########## Review Comment: I would add an explicit call to `sslFilter.setUseNonBlockingPipeline( true );` in both the client and server. It's not necessary, because it's the default, but it clarifies the intent of this test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
