On 10/02/06, Carlos Sanchez <[EMAIL PROTECTED]> wrote: > Sorry about late response, a lot of work lately. > > Some things that i believe are required before the release: > - rename what it's called Module to Dependency as it's the name used > all across maven, rename the class, parameters,documentation,... > > - mojos run in compile and test-compile phase, which mean that > standard java compiler may run before it, thus failing in some cases > (I believe is when a test class extends a main class already weaved). > Don't know if compiler can be removed from aspectj mojo or aspectj > should be moved to plexus compiler, if not it has to run in the > process-sources and process-test-sources phase.
The problem by putting it in the process sources phase is that the ajc compiler does nothing to the sourcefiles, but only to the classfiles, so if it is to work having it in the process sources phase, I need to know if a ajc compile would make the std java compiler to do nothing to that class afterwards and then overwrite any modifications ajc does to the class. > - test classes are not weaved with aspects from main folder, i'm > looking into this > > - use Default Value in mojo docs instead of putting defaults in the > description (use "default-value" attribute in the javadoc annotation) > > > And some questions > > - Weaving jars, where is the output saved? > > I think we need to think about these issues before making a 1.0 release. > > Regards > > On 2/8/06, Kaare Nilsen <[EMAIL PROTECTED]> wrote: > > Hi > > > > I would like to get this out, so have gotten around to testing it Carlos ? > > I would sure like to see if there are any errors in the > > implementation, or if your project not building is a result of the > > changes in the configuration. > > > > Of course you could just post your plugin configuration, and I can > > convert it for you in no time.. > > > > > > Best regards > > Kaare > > > > On 07/02/06, Kaare Nilsen <[EMAIL PROTECTED]> wrote: > > > and this time the entire mail (i hate touchpads ;)) > > > > > > You would need to see the examples at the site, I have done some > > > changes to the way you configure the plugin. but in short the > > > > > > <options> > > > <option>-showWeaveInfo</option> > > > </options> > > > has become > > > <showWeaveInfo>true</showWeaveInfo> > > > and so on. > > > > > > I have wanted to do so for a long time, and I wanted to get this > > > resolved before i took it out of the sandbox and people could start to > > > expect a stable api > > > > > > best regards > > > /Kaare > > > > > > > > > On 07/02/06, Kaare Nilsen <[EMAIL PROTECTED]> wrote: > > > > You would need to see the examples at the site, I have done some > > > > changes to the way you configure the plugin. but in short the > > > > <options> tag in the configuration is no longer supported and all > > > > supported compilerargs has their own properties in the plugin e.g > > > > <option> > > > > <option>-showWeaveInfo</option> > > > > </opt > > > > > > > > On 07/02/06, Carlos Sanchez <[EMAIL PROTECTED]> wrote: > > > > > -1 > > > > > > > > > > I've tried it in a project working with an old version that now is not > > > > > working anymore, so I need some time to test it. > > > > > > > > > > > > > > > On 2/6/06, John Casey <[EMAIL PROTECTED]> wrote: > > > > > > +1 > > > > > > > > > > > > Kaare Nilsen wrote: > > > > > > > Hi everyone, > > > > > > > > > > > > > > After long time of coding, I finally have a working, and feature > > > > > > > complete aspectj compiler plugin with good documentation and a > > > > > > > fairly > > > > > > > good testsuite. > > > > > > > > > > > > > > The plugin is already in daily use in several projects, and it > > > > > > > would > > > > > > > help theese projects if the plugin was available in an official > > > > > > > repository. > > > > > > > > > > > > > > Based on that i would like to graduate the plugin from the > > > > > > > sandbox and > > > > > > > make a first official beta-1 release > > > > > > > > > > > > > > I'll open up the vote for 72h, then provide a summary > > > > > > > > > > > > > > +1 from me > > > > > > > > > > > > > > Best regards > > > > > > > Kaare Nilsen > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > I could give you my word as a Spaniard. > No good. I've known too many Spaniards. > -- The Princess Bride >
