He already sends in the fix. I agree with your point about not being self-merging, but a proper way would bring this issue up friendly and move forward with a better fix. We should not shoot every contributor for a bug they introduced due to new features as long as they take responsibility to fix it.
Tianqi On Fri, Jun 15, 2018 at 2:27 PM, Marco de Abreu < [email protected]> wrote: > If it causes issues, I'd like to invite everybody to direct their requests > to Eric since he merged the PR prematurely. The committer who merges a PR > is responsible and can be held liable for any negative impact being the > result of their action [1]. > > [1]: https://www.apache.org/dev/committers.html#committer-responsibilities > > On Fri, Jun 15, 2018 at 2:23 PM Zheng, Da <[email protected]> > wrote: > > > +1 The PR has been merged a while ago, so it has been tested by many > > people. > > Other people's work now depends on this PR. Reverting it at this point > can > > cause a lot of problems for many other people. > > > > Best, > > Da > > > > On 6/15/18, 2:18 PM, "[email protected] on behalf of Tianqi Chen" < > > [email protected] on behalf of [email protected]> wrote: > > > > +1 We would be stuck at local minimums if we just keep reverting > the > > PR > > that brings improvements in the long term > > > > Tianqi > > > > On Fri, Jun 15, 2018 at 2:15 PM, Mu Li <[email protected]> wrote: > > > > > Why reverting instead of fixing the bugs? Static memory aims to > > reduce > > > memory allocation, it's a key feature to bridge the perf gap > between > > gluon > > > and symbol. > > > > > > On Fri, Jun 15, 2018 at 2:06 PM, Marco de Abreu < > > > [email protected]> wrote: > > > > > > > Hello, > > > > > > > > I'm reverting https://github.com/apache/ > incubator-mxnet/pull/10817 > > as of > > > > https://github.com/apache/incubator-mxnet/pull/11311 due to > > regressions > > > > described in > > https://github.com/apache/incubator-mxnet/issues/11171 and > > > > https://github.com/apache/incubator-mxnet/pull/10817. > > > > > > > > The pull request has been self-merged without proper review and > > > introduced > > > > regressions. Committers should act as role models in this project > > and > > > > adhere to software engineer best practices. > > > > > > > > Best regards, > > > > Marco > > > > > > > > > > > > > >
