-0

Thanks Steffen for your release efforts !

Build from source works with make but fails with cmake for me.

 cd build && cmake VERBOSE=1 -DUSE_CUDA=ON -DUSE_CUDNN=ON -DUSE_OPENMP=ON
-DCMAKE_BUILD_TYPE=Debug -DUSE_DIST_KVSTORE=0 -DUSE_OPENCV=1 -GNinja .. &&
ninja -v

FAILED: : && /usr/bin/c++   -Wall -Wno-unknown-pragmas -fPIC -g -O0 -msse2
-std=c++11 -fopenmp -g  -pthread
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_lockfree.cc.o
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_param.cc.o
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_parser.cc.o
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_array_view.cc.o
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_any.cc.o
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_config.cc.o
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_threaditer.cc.o
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_serializer.cc.o
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_threaditer_exc_handling.cc.o
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_inputsplit.cc.o
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_logging.cc.o
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_json.cc.o
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_optional.cc.o
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_main.cc.o
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_env.cc.o
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_thread_group.cc.o
-o 3rdparty/dmlc-core/test/unittest/dmlc_unit_tests  -rdynamic
lib/libgtestd.a 3rdparty/dmlc-core/libdmlc.a -lpthread && :
3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_logging.cc.o:
In function `Logging_basics_Test::TestBody()':
/home/ubuntu/experimentals/1.4_release/build/../3rdparty/dmlc-core/test/unittest/unittest_logging.cc:19:
undefined reference to `testing::internal::DeathTest::Create(char const*,
testing::internal::RE const*, char const*, int,
testing::internal::DeathTest**)'
collect2: error: ld returned 1 exit status


Anirudh

On Mon, Feb 4, 2019 at 3:09 PM Haibin Lin <haibin.lin....@gmail.com> wrote:

> +1 built from source on Linux and passed dist sync kvstore test.
>
> On Mon, Feb 4, 2019 at 9:54 AM Lin Yuan <apefor...@gmail.com> wrote:
>
> > +1 build from source on MacOS 10.13.6 and tested mxnet-to-coreml
> converter.
> >
> > On Mon, Feb 4, 2019 at 9:03 AM Indhu <indhubhara...@gmail.com> wrote:
> >
> > > +1
> > >
> > > Build from source and tested few examples from the examples folder.
> > >
> > > Thanks,
> > > Indu
> > >
> > >
> > >
> > > On Fri, Feb 1, 2019 at 6:21 PM Steffen Rochel <steffenroc...@gmail.com
> >
> > > wrote:
> > >
> > > > Hi Sheng - thanks for the feedback.
> > > > TVM notice  file is missing as the 1.4.x branch/v1.4.0 release is
> using
> > > TVM
> > > > commit 0f053c8
> > > > <
> > > >
> > >
> >
> https://github.com/dmlc/tvm/commit/0f053c82a747b4dcdf49570ec87c17e0067b7439
> > > > >
> > > >  from Oct 8, 2018, which didn't have the NOTICE file. IMHO, MXNet
> > NOTICE
> > > > file is consistent with release content.
> > > > As the release started in 2018 I do think it is ok to move forward
> w/o
> > > > update to 2019 IMHO.
> > > >
> > > > All -
> > > > thanks to the committers/contributors (Tao, Aaron, Kellen, Aston,
> Yuxi)
> > > who
> > > > tested and provided feedback - we have five +1 votes.
> > > > As of today, Friday Feb 1st 2019 6pm PST we have two binding votes,
> one
> > > +1
> > > > (Carin), one +0 (Sheng). The vote continues be open waiting for
> > feedback
> > > > from PMC members.
> > > > Hope you can spare some time over the weekend to provide feedback.
> > > >
> > > > Regards,
> > > > Steffen
> > > >
> > > > On Fri, Feb 1, 2019 at 12:44 AM Marco de Abreu <
> > marco.g.ab...@gmail.com>
> > > > wrote:
> > > >
> > > > > Considering the release process has been started last year and the
> > code
> > > > tag
> > > > > has also been based on last year, I'd say that it is not really a
> big
> > > > deal.
> > > > >
> > > > > -Marco
> > > > >
> > > > > Am Fr., 1. Feb. 2019, 09:33 hat Sheng Zha <szha....@gmail.com>
> > > > > geschrieben:
> > > > >
> > > > > > I found an awesome checklist for incubator releases [1] so I'm
> > using
> > > it
> > > > > > here:
> > > > > >
> > > > > > -[Y] Are release files in correct location?
> > > > > > -[Y] Do release files have the word incubating in their name?
> > > > > > -[Y] Are the digital signature and hashes correct?
> > > > > > -[Y] Does DISCLAIMER file exist?
> > > > > > -[Y] Do LICENSE and NOTICE files exists?
> > > > > > -[N/A] Is the LICENSE and NOTICE text correct? (sz: did not
> finish
> > > > > > checking)
> > > > > > -[N] Is the NOTICE year correct?
> > > > > > -[N/A] Un-included software dependencies are not mentioned in
> > LICENSE
> > > > or
> > > > > > NOTICE? (sz: did not finish checking)
> > > > > > -[Y] License information is not mentioned in NOTICE?
> > > > > > Is there any 3rd party code contained inside the release? If so:
> > > > > > -[Y] Does the software have a compatible license?
> > > > > > -[Y] Are all software licenses mentioned in LICENSE?
> > > > > > -[Y] Is the full text of the licenses (or pointers to it) in
> > LICENSE?
> > > > > > Is any of this code Apache licensed? Do they have NOTICE files?
> If
> > > so:
> > > > > > -[N] Have relevant parts of those NOTICE files been added to this
> > > > NOTICE
> > > > > > file?
> > > > > > TVM has Apache 2.0 license and its NOTICE hasn't been added to
> > > MXNet's
> > > > > > NOTICE file.
> > > > > > -[Y] Do all source files have ASF headers? (sz: enforced by
> license
> > > > > > checker)
> > > > > > -[Y] Do the contents of the release match with what's tagged in
> > > version
> > > > > > control?
> > > > > > -[N] Are there any unexpected binary files in the release?
> > > > > > -[Y] Can you compile from source? Are the instruction clear?
> > > > > >
> > > > > > Is the issue minor?
> > > > > > - Unsure. NOTICE year is wrong (it's 2019 now). TVM's NOTICE is
> > > missing
> > > > > > from MXNet's NOTICE file.
> > > > > > Could it possibly be fixed in the next release?
> > > > > > - Yes
> > > > > > I vote with:
> > > > > > +0 not sure if it should be released. Could mentors advise if we
> > > should
> > > > > fix
> > > > > > them before release?
> > > > > >
> > > > > > [1] https://wiki.apache.org/incubator/IncubatorReleaseChecklist
> > > > > >
> > > > > >
> > > > > > On Thu, Jan 31, 2019 at 10:56 PM Lv, Tao A <tao.a...@intel.com>
> > > wrote:
> > > > > >
> > > > > > >
> > > > > > > +1. Verified below items:
> > > > > > >
> > > > > > > 1. Checkout code from tag 1.4.0rc2 and build mkldnn backend
> > > > > successfully
> > > > > > > on both cpu and gpu w/ mkl and openblas
> > > > > > > 2. ResNet50v1 FP32 performance looks good for both latency and
> > > > > throughput
> > > > > > > 3. Quantization script works well with ResNet50v1
> > > > > > > 4. ResNet50v1 INT8 model accuracy looks good
> > > > > > > 5. ResNet50v1 INT8 model performance speedup looks good for
> both
> > > > > latency
> > > > > > > and throughput
> > > > > > >
> > > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: kellen sunderland [mailto:kellen.sunderl...@gmail.com]
> > > > > > > Sent: Friday, February 1, 2019 11:45 AM
> > > > > > > To: dev@mxnet.incubator.apache.org
> > > > > > > Subject: Re: [VOTE] Release Apache MXNet (incubating) version
> > > > 1.4.0.rc2
> > > > > > >
> > > > > > > Great, thanks Steffen!  I added a few key files but missed that
> > > one.
> > > > > > >
> > > > > > > +1 from me.
> > > > > > >
> > > > > > > On Thu, Jan 31, 2019 at 9:35 AM Steffen Rochel <
> > > > > steffenroc...@gmail.com>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Kellen - Sergey, the 1.4.0 release co-manager signed the tar
> > > file.
> > > > > > > > Please use his public key to validate the asc.
> > > > > > > > I was able to validate:
> > > > > > > >
> > > > > > > > curl
> > https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
> > > > -o
> > > > > > > > KEYS
> > > > > > > >
> > > > > > > > gpg --import KEYS
> > > > > > > >
> > > > > > > > gpg --verify apache-mxnet-src-1.4.0.rc2-incubating.tar.gz.asc
> > > > > > > >
> > > > > > > >
> > > > > > > > output:
> > > > > > > >
> > > > > > > > gpg: assuming signed data in
> > > > > > > 'apache-mxnet-src-1.4.0.rc2-incubating.tar.gz'
> > > > > > > >
> > > > > > > > gpg: Signature made Sat Jan 26 16:25:41 2019 PST
> > > > > > > >
> > > > > > > > gpg:                using RSA key
> > > > > > > BD52136E76B7BD68E7843B0B591C06669F740FD7
> > > > > > > >
> > > > > > > > gpg: Good signature from "Sergey Kolychev <
> > > > sergeykolyc...@apache.org
> > > > > >"
> > > > > > > > [unknown]
> > > > > > > >
> > > > > > > > gpg: WARNING: This key is not certified with a trusted
> > signature!
> > > > > > > >
> > > > > > > > gpg:          There is no indication that the signature
> belongs
> > > to
> > > > > the
> > > > > > > > owner.
> > > > > > > >
> > > > > > > > Primary key fingerprint: BD52 136E 76B7 BD68 E784  3B0B 591C
> > 0666
> > > > > 9F74
> > > > > > > > 0FD7
> > > > > > > >
> > > > > > > >
> > > > > > > > Best,
> > > > > > > > Steffen
> > > > > > > >
> > > > > > > > On Wed, Jan 30, 2019 at 10:39 PM kellen sunderland <
> > > > > > > > kellen.sunderl...@gmail.com> wrote:
> > > > > > > >
> > > > > > > > > +0
> > > > > > > > >
> > > > > > > > > Overall release looks good.  Probably something I'm doing
> > > wrong,
> > > > > but
> > > > > > > > > so
> > > > > > > > far
> > > > > > > > > not able to validate the .asc.  I'm getting "Can't check
> > > > signature:
> > > > > > > > > No public key".  I've added the keys from GitHub and the
> > > release
> > > > > > > > > folder, and also added your public key "40C9346904DFCE37"
> > from
> > > > the
> > > > > > > > > MIT key server Steffen.  Is there another key I'm missing?
> > > > > > > > >
> > > > > > > > > 1. sha512 look good.
> > > > > > > > > 2. Compile from source successfully
> > > > > > > > > 3. TensorRT build succeeds and runs inference for demo
> models
> > > 4.
> > > > > > > > > License, notice and disclaimer exist.
> > > > > > > > >
> > > > > > > > > -Kellen
> > > > > > > > >
> > > > > > > > > On Wed, Jan 30, 2019 at 8:58 PM Steffen Rochel
> > > > > > > > > <steffenroc...@gmail.com>
> > > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > Dear MXNet community -
> > > > > > > > > > we currently have three +1 votes, one binding.
> > > > > > > > > > As the vote did not reach the necessary number of binding
> > > votes
> > > > > > > > > > I'm extending voting.
> > > > > > > > > >
> > > > > > > > > > I'm calling on all PMC member, please test and vote.
> > > > > > > > > >
> > > > > > > > > > Regards,
> > > > > > > > > > Steffen
> > > > > > > > > >
> > > > > > > > > > On Wed, Jan 30, 2019 at 6:43 PM Aston Zhang
> > > > > > > > > > <astonlzh...@gmail.com>
> > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > > +1
> > > > > > > > > > >
> > > > > > > > > > > Tested with the Dive into Deep Learning book.
> > > > > > > > > > >
> > > > > > > > > > > On Wed, Jan 30, 2019 at 1:25 PM Steffen Rochel <
> > > > > > > > > steffenroc...@gmail.com>
> > > > > > > > > > > wrote:
> > > > > > > > > > >
> > > > > > > > > > > > Thanks Carin and Yuxi.
> > > > > > > > > > > >
> > > > > > > > > > > > Committers and PMC members - please test and send
> your
> > > vote
> > > > > to
> > > > > > > > > release
> > > > > > > > > > > > Apache MXNet (incubating) v1.4.0.
> > > > > > > > > > > >
> > > > > > > > > > > > Regards,
> > > > > > > > > > > > Steffen
> > > > > > > > > > > >
> > > > > > > > > > > > On Wed, Jan 30, 2019 at 10:55 AM Yuxi Hu
> > > > > > > > > > > > <darreny...@gmail.com>
> > > > > > > > > wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > > +1
> > > > > > > > > > > > >
> > > > > > > > > > > > > verified the training throughput for resnet50_v1
> > looks
> > > > > > > > > > > > > normal
> > > > > > > > > > compared
> > > > > > > > > > > to
> > > > > > > > > > > > > 1.3.1 release
> > > > > > > > > > > > >
> > > > > > > > > > > > > On Tue, Jan 29, 2019 at 3:36 PM Carin Meier <
> > > > > > > > carinme...@gmail.com>
> > > > > > > > > > > > wrote:
> > > > > > > > > > > > >
> > > > > > > > > > > > > > +1 - checked out from the release tag and built
> and
> > > > > tested
> > > > > > > > > > > > Scala/Clojure
> > > > > > > > > > > > > > package.
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > On Sat, Jan 26, 2019 at 8:53 PM Steffen Rochel <
> > > > > > > > > > > > steffenroc...@gmail.com>
> > > > > > > > > > > > > > wrote:
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Dear MXNet community,
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > This is the vote to release Apache MXNet
> > > (incubating)
> > > > > > > > > > > > > > > version
> > > > > > > > > > > v1.4.0.
> > > > > > > > > > > > > > > Voting will
> > > > > > > > > > > > > > > start today, Saturday January 26th 6pm PST and
> > will
> > > > > > > > > > > > > > > close on
> > > > > > > > > > > > Wednesday,
> > > > > > > > > > > > > > > January 30th 7pm PST.
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Link to release notes:
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > >
> > https://cwiki.apache.org/confluence/display/MXNET/Apache+MXNet+%28incu
> > > > > > > > bating%29+
> > > > > > > > > > > > > > > 1.4.0+Release+Notes
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Link to release candidate:
> > > > > > > > > > > > > > >
> > > > > https://github.com/apache/incubator-mxnet/releases/tag/
> > > > > > > > > > > > > > > <
> > > > > > > > > >
> > > > https://github.com/apache/incubator-mxnet/releases/tag/1.4.0.rc2
> > > > > > > > > > > > > > >1.4.0.rc
> > > > > > > > > > > > > > > <
> > > > > > > > > >
> > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.4.0.rc1
> > > > > > > > > > > >2
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Link to source and signatures on apache dist
> > > server:
> > > > > > > > > > > > > > >
> > > > > > > > >
> > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.4.0.rc2
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Please remember to TEST first before voting
> > > > > accordingly:
> > > > > > > > > > > > > > > +1 = approve
> > > > > > > > > > > > > > > +0 = no opinion
> > > > > > > > > > > > > > > -1 = disapprove (provide reason)
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Best regards,
> > > > > > > > > > > > > > > Steffen
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > --
> > > > > > > > > > > > > Yuxi(Darren) Hu, Ph.D.
> > > > > > > > > > > > > Software Development Engineer Amazon Web Services
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Reply via email to