johnyangk commented on a change in pull request #141: [NEMO-252] Fix 
CreatViewTransform to emit windowed materialized data
URL: https://github.com/apache/incubator-nemo/pull/141#discussion_r230245355
 
 

 ##########
 File path: 
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransform.java
 ##########
 @@ -179,7 +199,7 @@ private void triggerTimers(final K key,
     final List<TimerInternals.TimerData> timerDataList = 
getEligibleTimers(timerInternals);
 
     if (timerDataList.isEmpty()) {
-      return;
+      return Long.MAX_VALUE;
 
 Review comment:
   How about Optional.empty()?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to