johnyangk commented on a change in pull request #141: [NEMO-252] Fix
CreatViewTransform to emit windowed materialized data
URL: https://github.com/apache/incubator-nemo/pull/141#discussion_r230245057
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransform.java
##########
@@ -157,12 +175,14 @@ protected void beforeClose() {
/**
* Trigger times for current key.
* When triggering, it emits the windowed data to downstream operators.
+ * It returns the minimum output timestamp.
+ * If no data is emitted, it returns Long.MAX_VALUE.
* @param key key
* @param watermark watermark
* @param processingTime processing time
* @param synchronizedTime synchronized time
*/
Review comment:
@return
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
