johnyangk commented on a change in pull request #141: [NEMO-252] Fix
CreatViewTransform to emit windowed materialized data
URL: https://github.com/apache/incubator-nemo/pull/141#discussion_r230246375
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransform.java
##########
@@ -113,14 +115,19 @@ public void onData(final WindowedValue<KV<K, InputT>>
element) {
/**
* Process the collected data and trigger timers.
- * @param watermark current watermark
+ * @param inputWatermark current input watermark
* @param processingTime processing time
* @param synchronizedTime synchronized time
*/
- private void processElementsAndTriggerTimers(final Watermark watermark,
+ private void processElementsAndTriggerTimers(final Watermark inputWatermark,
final Instant processingTime,
final Instant synchronizedTime)
{
- keyToValues.forEach((key, val) -> {
+ long outputTimestamp = Long.MAX_VALUE;
+
+ for (final Map.Entry<K, List<WindowedValue<InputT>>> entry :
keyToValues.entrySet()) {
+ final K key = entry.getKey();
+ final List<WindowedValue<InputT>> val = entry.getValue();
Review comment:
val -> values
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
