johnyangk commented on a change in pull request #141: [NEMO-252] Fix
CreatViewTransform to emit windowed materialized data
URL: https://github.com/apache/incubator-nemo/pull/141#discussion_r230245211
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransform.java
##########
@@ -191,16 +211,15 @@ private void triggerTimers(final K key,
// output watermark
// we set output watermark to the minimum of the timer data
- long outputWatermark = Long.MAX_VALUE;
+ long keyOutputTimestamp = Long.MAX_VALUE;
for (final TimerInternals.TimerData timer : timerDataList) {
- if (outputWatermark > timer.getTimestamp().getMillis()) {
- outputWatermark = timer.getTimestamp().getMillis();
+ if (keyOutputTimestamp > timer.getTimestamp().getMillis()) {
Review comment:
Math.min?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
