[GitHub] johnyangk commented on a change in pull request #153: [NEMO-245, 247] Handle watermark in OutputWriter and Implement unbounded word count example

[GitBox]

johnyangk commented on a change in pull request #153: [NEMO-245,247] Handle 
watermark in OutputWriter and Implement unbounded word count example
URL: https://github.com/apache/incubator-nemo/pull/153#discussion_r232157411
 
 

 ##########
 File path: 
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/datatransfer/MultiInputWatermarkManager.java
 ##########
 @@ -74,7 +84,10 @@ public void trackAndEmitWatermarks(final int edgeIndex, 
final Watermark watermar
       if (minWatermark.getTimestamp() > prevMinWatermark.getTimestamp()) {
         // Watermark timestamp progress!
         // Emit the min watermark
-        nextOperator.getTransform().onWatermark(minWatermark);
+        if (LOG.isDebugEnabled()) {
+          LOG.debug("Emit watermark {}, {}", minWatermark, watermarks);
 
 Review comment:
   Please remove
   (To avoid the possibility of printing data elements)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services