johnyangk commented on a change in pull request #153: [NEMO-245,247] Handle
watermark in OutputWriter and Implement unbounded word count example
URL: https://github.com/apache/incubator-nemo/pull/153#discussion_r232546566
##########
File path:
common/src/main/java/org/apache/nemo/common/coder/BytesDecoderFactory.java
##########
@@ -84,7 +88,7 @@ private BytesDecoder(final InputStream inputStream) {
returnedArray = true;
return new byte[0];
} else {
- throw new IOException("EoF (empty partition)!"); // TODO #120: use
EOF exception instead of IOException.
+ throw new EOFException("EoF (empty partition)!"); // TODO #120: use
EOF exception instead of IOException.
Review comment:
Remove TODO?
and does this change resolve the same TODOs in `BytesDecoderFactory` and
`DecoderFactory`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
