johnyangk commented on a change in pull request #153: [NEMO-245,247] Handle
watermark in OutputWriter and Implement unbounded word count example
URL: https://github.com/apache/incubator-nemo/pull/153#discussion_r232549408
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/task/TaskExecutor.java
##########
@@ -160,9 +174,9 @@ public TaskExecutor(final Task task,
// in {@link this#getInternalMainOutputs and this#internalMainOutputs}
final Map<RuntimeEdge<IRVertex>, Integer> edgeIndexMap = new HashMap<>();
reverseTopologicallySorted.forEach(childVertex -> {
- final List<RuntimeEdge<IRVertex>> edges =
irVertexDag.getIncomingEdgesOf(childVertex);
+ final List<Object> edges = getIncomingEdges(task, irVertexDag,
childVertex);
for (int edgeIndex = 0; edgeIndex < edges.size(); edgeIndex++) {
- final RuntimeEdge<IRVertex> edge = edges.get(edgeIndex);
+ final RuntimeEdge<IRVertex> edge = (RuntimeEdge<IRVertex>)
edges.get(edgeIndex);
Review comment:
Remove the type casting? (Some edges may be an IREdge)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
