johnyangk commented on a change in pull request #153: [NEMO-245,247] Handle watermark in OutputWriter and Implement unbounded word count example URL: https://github.com/apache/incubator-nemo/pull/153#discussion_r232157712
########## File path: examples/beam/src/main/java/org/apache/nemo/examples/beam/WindowedWordCount.java ########## @@ -41,19 +43,64 @@ private WindowedWordCount() { } + public static final String INPUT_TYPE_BOUNDED = "bounded"; Review comment: Make it an Enum? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services