Github user phansson commented on a diff in the pull request:

    https://github.com/apache/incubator-netbeans/pull/2#discussion_r139601775
  
    --- Diff: o.n.core/src/org/netbeans/core/NbAuthenticator.java ---
    @@ -61,6 +63,7 @@
      */
     final class NbAuthenticator extends java.net.Authenticator {
    --- End diff --
    
    I actually did that initially. (i.e. registering self as a service). But it 
requires a public no-arg constructor and I didn't have time to analyze why the 
original author insisted on a private constructor and since it wouldn't 
actually bring any benefit - besides a bit cleaner code - I then discarded the 
idea. But I have no objections to do this change.


---

Reply via email to