Github user phansson commented on a diff in the pull request:

    https://github.com/apache/incubator-netbeans/pull/2#discussion_r139614856
  
    --- Diff: o.n.core/src/org/netbeans/core/NbAuthenticator.java ---
    @@ -71,7 +74,19 @@ private NbAuthenticator() {
     
         static void install() {
             if (Boolean.valueOf(NbBundle.getMessage(GuiRunLevel.class, 
"USE_Authentication"))) {
    -            setDefault(new NbAuthenticator());
    +            // Look for custom authenticator
    +            Authenticator authenticator = 
Lookup.getDefault().lookup(Authenticator.class);
    +            if (authenticator == null) {
    +                authenticator = new NbAuthenticator();
    +            }
    +            if (authenticator.getClass().equals(NbAuthenticator.class)) {
    --- End diff --
    
    I can can think of a dozen reason why you might want to override the 
Authenticator on a *existing* application, i.e. use of Plugin. It is actually 
quite difficult to design an Authenticator which fits everyone's taste. For 
example imagine you are on a site where you have an alternative way that you 
can obtain credentials.


---

Reply via email to