Github user phansson commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/2#discussion_r139604336
--- Diff: o.n.core/src/org/netbeans/core/NbAuthenticator.java ---
@@ -71,7 +74,19 @@ private NbAuthenticator() {
static void install() {
if (Boolean.valueOf(NbBundle.getMessage(GuiRunLevel.class,
"USE_Authentication"))) {
- setDefault(new NbAuthenticator());
+ // Look for custom authenticator
+ Authenticator authenticator =
Lookup.getDefault().lookup(Authenticator.class);
+ if (authenticator == null) {
+ authenticator = new NbAuthenticator();
+ }
+ if (authenticator.getClass().equals(NbAuthenticator.class)) {
--- End diff --
Why is it static? The idea is that people can add their own
Authenticators. Heck, I might even publish my own version as a plugin in the
Plugin Portal and ask users to use my plugin if I believe I've come up with
something brilliant which is better than the standard NbAuthenticator. And
that situation [already
exists](https://bitbucket.org/phansson/netbeansnetworkauthenticator).
---
