[GitHub] incubator-netbeans pull request #2: Allow custom authenticator

[emilianbold]

Github user emilianbold commented on a diff in the pull request:

    https://github.com/apache/incubator-netbeans/pull/2#discussion_r139602349
  
    --- Diff: o.n.core/src/org/netbeans/core/NbAuthenticator.java ---
    @@ -61,6 +63,7 @@
      */
     final class NbAuthenticator extends java.net.Authenticator {
    --- End diff --
    
    Ah, I see, and `NbAuthenticator` is package private too. I guess this is 
just standard NetBeans architecture of not over-exposing more than necessary.
    
    I guess:
    * we could either make `NbAuthenticator` class and constructor public or
    * introduce a `AuthenticatorFactory` which will be registered in the lookup 
with a default factory producing `NbAuthenticator` or
    * use your current solution
    



---