Just in case someone would miss the e-mail on general, I'm forwarding Justin's e-mail about issues he has found in the 9.0 beta RC2.
There are multiple things to solve, but here, among others: 1. the various xsd/dtd/css/etc. files which are in the sources and whose licenses are not in the LICENSE file. There may be different solutions for different such files, but to me, it would seem OK if all those would be downloaded as external binaries. Although in any case, we may need to do some infrastructure work. I wonder if folks knowledgeable of those files could take a look. 2. icons: besides icons that were in the donation (about which I hope someone could comment), I believe we were adding some other icons, right? I think we need to clarify their status and make sure all requirements are met. When I have time, I personally intend to: -delete the lib.terminalemulator/examples/lib.richexecution/ zips -look at the SFS-Editors-Folder.zip (from editor.settings.storage) -look if we can add license headers to stuff under */test/*/data without manually updating every test that uses them Then there are still some other things to do, like solving the images in javafx2.samples, the patch files, etc., which we will need to look at. Jan ---------- Forwarded message ---------- From: Justin Mclean <jus...@classsoftware.com> Date: Sat, Jan 20, 2018 at 5:49 AM Subject: Re: [VOTE] Release Apache NetBeans 9.0 Beta (incubating) rc2 To: gene...@incubator.apache.org Hi, It -1 (binding) as there may be GPL inclusions in the release and Category B software in a source release, the source release LICENSE is missing several things, and the binary LICENSE and NOTICE contains too much and the source release contains compiled source, may also be some images that you don’t have permission to use or distribute. Some of these may turn out to be minor issues but they need to be clarified. Please ask your mentors to help on fixing up the LICENSE and/or read this [1]. Some time ago I also made this which may help. [2][3] I suggest you also run rat on the release to find some of these issues I found. I checked: - incubating in name - disclaimer exists - LICENSE has a number of issues (see below) - NOTICE is OK - There’s a number of file that are missing ASF headers, including 700 odd java files, and a large number number of xml, dtd, wdsl, xsd and files containing code ending with .pass. - unexpected binary files in the source release [26][27][28][29] (these contain compiled code) Several (not dual license) GPL license files exist in the source release. Does this software include GPL or depend on any GPL licensed software? For instance [4][19] There a large number of icons in the release do know the ip provenance of them and how they are licensed? There also seems to be a number of stock photos [30][31][32] in the release. How are they licensed? Do you have permission to use or distribute them? LICENSE is missing licenses for: - CDDL licensed this [5] and about 100 others inside SFS-Editors-Folder.zip - These CDDL/GPL licensed files [7][8][10] and a number of files like this one is [9] - this patch file seems to be removing a GPL/CDDL header [6] - these EPL licensed files [11][12][13][14][15][16] - these files under the sun public license [17][18] - this MIT licensed file [20] (which also includes MIT licensed normalize.css) - this patch seems to be removing a MIT license header [21] - this IOS file [22] (and about a dozen other files) - how is this file licensed? [23] - this WC3 license file [24] and a dozen others However CDDL, EPL and the sun public license are in Category B [25] and not allowed is source form in a release. I glanced at the binary LICENSE and NOTICE of the binary and I think there's too much information in there. - There is no need to repeat the Apache license text several times - Only 3rd party software that is bundled in the source release needs to be mention in LICENSE and NOTICE. Is everything mentioned really bundled? - NOTICE seems to contain too much information - For long licenses it best to use a pointer the the full text of the license rather than include the full text Thanks, Justin 1. http://www.apache.org/dev/licensing-howto.html 2. https://vimeo.com/171210141 3. https://github.com/justinmclean/ApacheWombat 4. nbbuild/licenses/LGPL-2.1 5. test/unit/src/org/netbeans/modules/editor/settings/ storage/compatibility/p1/SFS-Editors-Folder.zip/Editors/ AnnotationTypes/Breakpoint.xml 6. css.lib/src/org/netbeans/modules/css/lib/antlrv4.patch 7. j2ee.persistence/src/org/netbeans/modules/j2ee/ persistence/dd/resources/orm_1_0.xsd 8. j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/ persistence_1_0.xsd 9. refactoring.java/test/qa-functional/data/goldenfiles/ org/netbeans/modules/test/refactoring/MoveTest/testMoveClass.pass 10. websvc.saas.api/src/org/netbeans/modules/websvc/saas/ model/wadl20061109.xsd 11. xml.jaxb/src/org/netbeans/modules/xml/jaxb/resources/ eclipselink_oxm_2_3.xsd 12. maven.coverage/src/org/netbeans/modules/maven/coverage/jacoco-1.0.dtd 13. j2ee.persistence/src/org/netbeans/modules/j2ee/ persistence/dd/resources/orm_2_0.xsd 14. j2ee.persistence/src/org/netbeans/modules/j2ee/ persistence/dd/resources/orm_2_1.xsd 15. j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/ persistence_2_0.xsd 16. j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/ persistence_2_1.xsd 17. diff/test/unit/src/org/netbeans/modules/diff/builtin/ provider/DiffTestFile1a.txt 18. diff/test/unit/src/org/netbeans/modules/diff/builtin/ provider/DiffTestFile1b.txt 19 apisupport.installer/src/org/netbeans/modules/apisupport/ installer/resources/licenses/GPL 20. css.model/test/unit/data/testfiles/bootstrap.css 21. html.validation/external/validator.patch 22. html.editor/src/org/netbeans/modules/html/editor/resources/ DTDs/4_0/HTMLlat1.ent 23. welcome/src/org/netbeans/modules/welcome/resources/rss-0_91.dtd 24. src/org/netbeans/modules/xml/catalog/resources/Transform.xsd 25. https://www.apache.org/legal/resolved.html#category-b 26. ./lib.terminalemulator/examples/lib.richexecution/ process_start-linux-intel.zip 27. ./lib.terminalemulator/examples/lib.richexecution/ process_start-mac-intel.zip 28. ./lib.terminalemulator/examples/lib.richexecution/ process_start-solaris-intel.zip 29. ./lib.terminalemulator/examples/lib.richexecution/ process_start-solaris-sparc.zip 30. ./netbeans/javafx2.samples/DisplayShelf/src/displayshelf/animalX.jpg 31. ./netbeans/javafx2.samples/Fireworks/src/Fireworks/sf.jpg 32. ./netbeans/javafx2.samples/PuzzlePieces/src/puzzlepieces/ PuzzlePieces-picture.jpg --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
