Hi, I have nothing particular against Review Board, but a few comments: -I am a little bit concerned about having too many venues for reviewing patches. It requires "reviewers" to monitor/work with several tools (it is hard to imagine how having multiple venues could speed up reviews, which is one of the problems we currently have, I think). -on GitHub we currently build the PRs using Travis CI, it would be unfortunate to loose that. Seems Review Board supports Travis CI as well - if we would start to use Review Board, can we please have that enabled?
(On a convenience note, in review board, a committer needs to download the patch, commit it locally and then push, right? Feels less convenient than the GH's green button; and potentially more error prone as well (although I could see an argument that doing it manually is safer).) (As a second note, frankly, I wonder if we really need all patches to go through a review...) Jan On Wed, Jun 13, 2018 at 6:57 PM, Emilian Bold <emilian.b...@protonmail.ch> wrote: > One person's 'knee jerk reaction' is another person's contingency plan... > When did we decide to marry GitHub? > > I created the PR (or "review") by creating an account on > reviews.apache.org and just using the tool (there's a 'New Review > Request' action). > > More documentation about the tool can be found at > https://www.reviewboard.org , makes no sense to compare workflows or some > such. > > reviews.apache.org needs a separate account to be created and I don't > believe it necessarily has to be an Apache ID (but I haven't tested). > > Anyhow, I'd say that more than half of the existing GitHub PRs are made by > existing committers which could easily switch to reviews.apache.org . > > Note that I'm not saying we should drop GitHub entirely, but demote it to > a plain Git mirror and a secondary venue for PRs. > > I don't think GitHub has that many things going for it actually: > > * how many new developers added PRs in the last months? With all the > developers having accounts there, GitHub is not really providing an > ever-increasing flow of new people. > > * how many developers are creating a (or re-activating their dormant) > GitHub account just to contribute to NetBeans? If they are neutral about > this and just care about the contribution, another site for PRs would > accomplish the same. Some might even *prefer* to use an .apache.org site > for this. > > * how many PRs will we lose if we keep GitHub the only venue for PRs? > Sure, we can say that emailing a patch file is just the same but look at > this: https://reviews.apache.org/r/67570/diff/1#index_header It's easier > on the eye than a plain patch and doesn't seem like such a loss compared to > GitHub, no? > > --emi > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > > On 13 June 2018 7:00 PM, John McDonnell <mcdonnell.j...@gmail.com> wrote: > > > I think I'm missing something, but how did you create the PR that this > review site picked up? - Whats the workflow of this from someone just > coming to NetBeans? and how specifically does it differ to the workflow of > someone willing to use GitHub? > > > > Also whats the point? A developer is more than likely to have a GitHub > account as opposed to an Apache ID - Which I think you only get when you > become a committer on an Apache Project no? > > > > To me this seems like a knee-jerk reaction to the news that Microsoft is > buying GitHub which I still don't see the problem with... > > > > Regards > > > > John > > > > On Wed, 13 Jun 2018 at 16:53, Emilian Bold <emilian.b...@protonmail.ch> > wrote: > > > > > > Git repo: https://github.com/apache/incubator-netbeans.git > > > > > > > > > > > > > > The above info is available like any other project on GitHub: > > > > > > > > > > > > > > https://github.com/apache/incubator-netbeans > > > > > > > > > > > > > > Go to the above link and click the green "Clone or download" button. > > > > > > This thread is about everything else except the git repo which can be > trivially cloned from Apache or any other mirror: > > > > > > * how does one start a new PR without a GitHub account? > > > > > > * how does one comment and +1 an existing PR? > > > > > > One first step towards fixing this is if we start using > https://reviews.apache.org/groups/netbeans/ which is provided by Apache > Software Foundation itself. > > > > > > --emi > > > > > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > > > > > > On 13 June 2018 5:49 PM, Geertjan Wielenga < > geertjan.wiele...@googlemail.com> wrote: > > > > > > > Git repo: https://github.com/apache/incubator-netbeans.git > > > > > > > > > > > > > > The above info is available like any other project on GitHub: > > > > > > > > > > > > > > https://github.com/apache/incubator-netbeans > > > > > > > > > > > > > > Go to the above link and click the green "Clone or download" button. > > > > > > > > > > > > > > Gj > > > > > > > > > > > > > > On Wed, Jun 13, 2018 at 4:41 PM, Glenn Holmer ce...@kolabnow.com > wrote: > > > > > > > > > > > > > > > On 06/13/2018 08:34 AM, Emilian Bold wrote: > > > > > > > > > > > > > > > > > Review Board for code reviews is working for NetBeans! > > > > > > > > > > > > > > > > > > I've just created the first review: > > > > > > > > > > > > > > > > > > https://reviews.apache.org/r/67570/ > > > > > > > > > > > > > > > > > > I invite everyone to give this a try and join the 'netbeans' > group on > > > > > > > > > > > > > > > > > > reviews.apache.org > > > > > > > > > > > > > > > > Excellent. > > > > > > > > > > > > > > > > > > On 7 June 2018 11:59 AM, Emilian Bold > emilian.b...@protonmail.ch wrote: > > > > > > > > > > > > > > > > > > > > > > > I think we need to plan a separate contribution workflow > > > > > > > > > > > > > > > > > > > > > > > > > > without GitHub (see my other thread 'How to participate > in > > > > > > > > > > > > > > > > > > > > > > > > > > Apache NetBeans without a GitHub account?'). > > > > > > > > > > > > > > > > > > > > > > > > > > Right now we are tied to GitHub and it's impossible to be > > > > > > > > > > > > > > > > > > > > > > > > > > involved in anything without jumping onto GitHub. > > > > > > > > > > > > > > > > > > > > > > > > Not sure if (or why) it is impossible to be involved > without > > > > > > > > > > > > > > > > > > > > > > > > GitHub. AFAIK anyone can subscribe to this mailing list, > > > > > > > > > > > > > > > > > > > > > > > > checkout from the Git repo on Apache: > > > > > > > > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=incubator-netbeans.git > > > > > > > > > > > > > > > > > > > > > > > and send patches to this mailing list. > > > > > > > > > > > > > > > > > > > > > > > > What's the correct way to clone that? > > > > > > > > > > > > > > > > cenbe@greyhand:/mnt/common/temp > git clone > https://gitbox.apache.org/ > > > > > > > > > > > > > > > > repos/asf?p=incubator-netbeans.git ./incubator-netbeans > > > > > > > > > > > > > > > > Cloning into './incubator-netbeans'... > > > > > > > > > > > > > > > > fatal: repository 'https://gitbox.apache.org/ > repos/asf?p=incubator- > > > > > > > > > > > > > > > > netbeans.git/' not found > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > Glenn Holmer (Linux registered user #16682) > > > > > > > > > > > > > > > > "After the vintage season came the aftermath -- and Cenbe." > > > > > > > > > > > > > > > > To unsubscribe, e-mail: dev-unsubscribe@netbeans. > incubator.apache.org > > > > > > > > > > > > > > > > For additional commands, e-mail: dev-help@netbeans.incubator. > apache.org > > > > > > > > > > > > > > > > For further information about the NetBeans mailing lists, visit: > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org > > > > > > For additional commands, e-mail: dev-help@netbeans.incubator. > apache.org > > > > > > For further information about the NetBeans mailing lists, visit: > > > > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org > For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
