Yes, it seems to be patch-based. You first upload the patch (pre- or post-commit) then you can set the branch this patch is for.
This is actually something I want to test: does Review Board show the proper diff based on the branch you tell it or does it just show the stuff in the patch? In theory what's in the patch should be enough, but I'm curious if the tool is smart enough to look at git branches. It's 'refreshing' that Apache is just like any corporation. Single-sign-on for the random mix of internal tools is truly a herculean task that few accomplish. --emi ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On 13 June 2018 8:46 PM, Matthias Bläsing <[email protected]> wrote: > Hello, > > I just looked at review board and the first thing I'm asking myself: > > How do I start a review based on a git branch? "New review request" > > requires me to upload a diff, that is not what I want. > > This leads me to the question: As a committer I could push a branch > > into the netbeans apache repository, but an outside committer would > > need to be able to ask the system to pull from a remote source. > > Can someone help? Oh and I'm now up to three accounts I need just for > > apache... At that point my happiness dropped. > > Greetings > > Matthias > > > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
