I am +0 (on the basis that you aren't expecting the failures under Windows) but I'm happy to change to +1 if I am doing something wrong or if you believe it is something in my environment. I had no problems under Linux.
I checked: - "incubating" in name - DISCLAIMER exists - LICENSE and NOTICE look good - no unexpected binary files - signature/hashes okay - rat check fails with no profile supplied but passes when given -Prelease (I assume that is okay?) (I'd suggest removing <numUnapprovedLicenses>1000000</numUnapprovedLicenses> and adding exclude for .yaml files) - "mvn clean package verify" passes on Linux under JDK11 (No appearance of Stanford or other GPL files with normal default profile) - "mvn clean verify" fails under Windows JDK8 and 11 (see below) Windows Surefire Failure: [ERROR] Errors: > [ERROR] > NCEnricherNestedModelSpec.test:41->NCEnricherBaseSpec.runBatch:153 ยป > TestFailed > [ERROR] Tests run: 29, Failures: 0, Errors: 1, Skipped: 1 > !!! Failed 3 from 3 tests. See errors list above. !!! > at > org.apache.nlpcraft.probe.mgrs.nlp.enrichers.model.NCEnricherNestedModelSpec.test(NCEnricherNestedModelSpec.scala:41) There are errors like below throughout the console logs (possibly relevant or perhaps a red herring): [INFO] Caused by: java.lang.ClassNotFoundException: Optimized stream class > checksum mismatch (is same version of marshalled class present on all > nodes?) [expected=32321, actual=26723, cls=class > scala.collection.immutable.Vector] > ... > [INFO] at > org.apache.ignite.internal.binary.BinaryFieldAccessor.read(BinaryFieldAccessor.java:188) > ~[apache-nlpcraft-incubating-0.6.1-all-deps.jar:0.6.1] > Jun.-09 18:20:58 [INFO ] 'ask' request 'tomorrow yesterday' answered > unsuccessfully with error: Unexpected response [code=420, text=Unable to > serve response within time limit, please enhance your calm.] > ... > [INFO] Caused by: java.io.IOException: Failed to deserialize object > [typeName=scala.collection.mutable.HashSet] > ... > [INFO] Caused by: org.apache.ignite.IgniteCheckedException: Failed to > deserialize object with given class loader: > [clsLdr=jdk.internal.loader.ClassLoaders$AppClassLoader@30946e09, > err=Failed to deserialize object > [typeName=scala.collection.mutable.HashSet]] > ... > [INFO] Caused by: org.apache.ignite.binary.BinaryObjectException: Failed > to unmarshal object with optimized marshaller > ... > [INFO] Caused by: org.apache.ignite.binary.BinaryObjectException: Failed > to deserialize object > [typeName=org.apache.nlpcraft.common.nlp.NCNlpSentenceToken] Let me know if you need more complete stack traces or need a Jira issue created. While it seems like numerous errors, I expect they are all related. Cheers, Paul. On Tue, Jun 9, 2020 at 5:21 AM Aaron Radzinski <[email protected]> wrote: > NLPCraft-ers, > This is the vote for release of NLPCraft v0.6.1. This release includes a > number of bug fixes, including the fix for pulling GPL-libraries during the > build. All 3-rd party dependencies now live in their own non-default maven > profile. > > Quick links: > 1. Release location: > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.6.1/ > 2. GitHub v0.6.0 tag: > https://github.com/apache/incubator-nlpcraft/tree/v0.6.1 > 3. JIRA issues closed: > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347775 > 4. KEYS file: > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS > > The vote is formal, see voting guidelines here: > https://www.apache.org/foundation/voting.html > +1 - to accept Apache NLPCraft 0.6.1 > 0 - don't care either way > -1 - DO NOT accept Apache NLPCraft 0.6.1 (explain why) > > See notes on how to verify release here: > https://www.apache.org/info/verification.html > > The vote will be held for 72 hours and will end on June 11, 2020 at > midnight MSK. > > Thank you! > -- > Aaron Radzinski >
