Okay, if you believe it is a platform specific thing, I will change my vote to +1. The tests ran fine for me under Ubuntu natively and under WSL2 on the Windows machine. I'd recommend a small note in your ANNOUNCE email (or README) suggesting Windows users use WSL2 if they run into any problems.
Cheers, Paul. On Wed, Jun 10, 2020 at 3:22 AM Sergey Kamov <[email protected]> wrote: > +1 > > tested under win (JDK8) and mac (JDK8) > > -`maven clean verify` > > - examples tests > > - files > > > Remark pom.xml scm tag <tag>0.6.0</tag> is incorrect. It should be > `v0.6.1` - please don't miss it next time. > > > Paul. I have created additional ticket, > https://issues.apache.org/jira/browse/NLPCRAFT-77, so we with your help > we have 4 new tickers which can significantly improve and simplify test > procedure for next release. > > About current release, my opinion that these tests issues (for win) are > not critical and can be fixed in next release. > > Thank you, > > > Sergey > > > 09.06.2020 16:50, Paul King пишет: > > I added the log for the first failing test to: > > > > https://issues.apache.org/jira/browse/NLPCRAFT-76 > > > > The other tests look similar but let me know if you want them also. > > > > Cheers, Paul. > > > > > > On Tue, Jun 9, 2020 at 9:44 PM Sergey Kamov <[email protected]> > wrote: > > > >> Hi Paul > >> Thank you for your remarks. > >> > >> There are 3 kinds of problem > >> > >> 1) Some deserialization warnings > >> >> Failed to unmarshal object with optimized marshaller > >> .. > >> I have created ticket - > https://issues.apache.org/jira/browse/NLPCRAFT-75 > >> These warnings are not critical for our release I guess, but we have to > >> fix it of course (warnings are always confused) > >> > >> 2. Problems with test, which ask data from some external weather data > >> provider (weather service test) > >> >> 'ask' request 'tomorrow yesterday' answered > >> >> unsuccessfully with error: Unexpected response [code=420, > >> text=Unable to serve response within time limit, please enhance your > calm.] > >> > >> Sometimes this free external service doesn't work well. > >> https://issues.apache.org/jira/browse/NLPCRAFT-74 created. > >> > >> I guess we can't depend on such external service in our suite, so these > >> tests should be refactored or excluded from suite. > >> It is not our release bug too, but better to fix it > >> > >> 3. Third error - most unexpected. > >> >>!!! Failed 3 from 3 tests. See errors list above. !!! > >> > >> > org.apache.nlpcraft.probe.mgrs.nlp.enrichers.model.NCEnricherNestedModelSpec.test(NCEnricherNestedModelSpec.scala:41) > >> > >> I have tested under win10, mac and linux - everything passed. I can't > >> reproduce it. > >> > >> Could you provide, when you have time, whole log for 'mvn clean verify' > >> via new Jira issue or email? > >> > >> Thank you > >> > >> Sergey > >> > >>> I am +0 (on the basis that you aren't expecting the failures under > >> Windows) > >>> but I'm happy to change to +1 if I am doing something wrong or if you > >>> believe it is something in my environment. I had no problems under > Linux. > >>> > >>> I checked: > >>> > >>> - "incubating" in name > >>> - DISCLAIMER exists > >>> - LICENSE and NOTICE look good > >>> - no unexpected binary files > >>> - signature/hashes okay > >>> - rat check fails with no profile supplied but passes when given > >> -Prelease > >>> (I assume that is okay?) > >>> (I'd suggest removing > >>> <numUnapprovedLicenses>1000000</numUnapprovedLicenses> and adding > exclude > >>> for .yaml files) > >>> - "mvn clean package verify" passes on Linux under JDK11 > >>> (No appearance of Stanford or other GPL files with normal default > >> profile) > >>> - "mvn clean verify" fails under Windows JDK8 and 11 (see below) > >>> > >>> Windows Surefire Failure: > >>> > >>> [ERROR] Errors: > >>>> [ERROR] > >>>> NCEnricherNestedModelSpec.test:41->NCEnricherBaseSpec.runBatch:153 » > >>>> TestFailed > >>>> [ERROR] Tests run: 29, Failures: 0, Errors: 1, Skipped: 1 > >>>> !!! Failed 3 from 3 tests. See errors list above. !!! > >>>> at > >>>> > >> > org.apache.nlpcraft.probe.mgrs.nlp.enrichers.model.NCEnricherNestedModelSpec.test(NCEnricherNestedModelSpec.scala:41) > >>> There are errors like below throughout the console logs (possibly > >> relevant > >>> or perhaps a red herring): > >>> > >>> [INFO] Caused by: java.lang.ClassNotFoundException: Optimized stream > >> class > >>>> checksum mismatch (is same version of marshalled class present on all > >>>> nodes?) [expected=32321, actual=26723, cls=class > >>>> scala.collection.immutable.Vector] > >>>> ... > >>>> [INFO] at > >>>> > >> > org.apache.ignite.internal.binary.BinaryFieldAccessor.read(BinaryFieldAccessor.java:188) > >>>> ~[apache-nlpcraft-incubating-0.6.1-all-deps.jar:0.6.1] > >>>> Jun.-09 18:20:58 [INFO ] 'ask' request 'tomorrow yesterday' answered > >>>> unsuccessfully with error: Unexpected response [code=420, text=Unable > to > >>>> serve response within time limit, please enhance your calm.] > >>>> ... > >>>> [INFO] Caused by: java.io.IOException: Failed to deserialize object > >>>> [typeName=scala.collection.mutable.HashSet] > >>>> ... > >>>> [INFO] Caused by: org.apache.ignite.IgniteCheckedException: Failed to > >>>> deserialize object with given class loader: > >>>> [clsLdr=jdk.internal.loader.ClassLoaders$AppClassLoader@30946e09, > >>>> err=Failed to deserialize object > >>>> [typeName=scala.collection.mutable.HashSet]] > >>>> ... > >>>> [INFO] Caused by: org.apache.ignite.binary.BinaryObjectException: > Failed > >>>> to unmarshal object with optimized marshaller > >>>> ... > >>>> [INFO] Caused by: org.apache.ignite.binary.BinaryObjectException: > Failed > >>>> to deserialize object > >>>> [typeName=org.apache.nlpcraft.common.nlp.NCNlpSentenceToken] > >>> Let me know if you need more complete stack traces or need a Jira issue > >>> created. While it seems like numerous errors, I expect they are all > >> related. > >>> Cheers, Paul. > >>> > >>> > >>> On Tue, Jun 9, 2020 at 5:21 AM Aaron Radzinski < > >> [email protected]> > >>> wrote: > >>> > >>>> NLPCraft-ers, > >>>> This is the vote for release of NLPCraft v0.6.1. This release > includes a > >>>> number of bug fixes, including the fix for pulling GPL-libraries > during > >> the > >>>> build. All 3-rd party dependencies now live in their own non-default > >> maven > >>>> profile. > >>>> > >>>> Quick links: > >>>> 1. Release location: > >>>> > >> > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.6.1/ > >>>> 2. GitHub v0.6.0 tag: > >>>> https://github.com/apache/incubator-nlpcraft/tree/v0.6.1 > >>>> 3. JIRA issues closed: > >>>> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347775 > >>>> 4. KEYS file: > >>>> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS > >>>> > >>>> The vote is formal, see voting guidelines here: > >>>> https://www.apache.org/foundation/voting.html > >>>> +1 - to accept Apache NLPCraft 0.6.1 > >>>> 0 - don't care either way > >>>> -1 - DO NOT accept Apache NLPCraft 0.6.1 (explain why) > >>>> > >>>> See notes on how to verify release here: > >>>> https://www.apache.org/info/verification.html > >>>> > >>>> The vote will be held for 72 hours and will end on June 11, 2020 at > >>>> midnight MSK. > >>>> > >>>> Thank you! > >>>> -- > >>>> Aaron Radzinski > >>>> >
