Hi Jaques, All the answers are pretty obvious (to me at least) after a minute's look at the commit, but I'll humor you anyway.
On 8/04/2012, at 10:08 PM, Jacques Le Roux wrote: > Hi Scott, > > So you committed this I see now > http://svn.apache.org/viewvc?rev=1040016&view=rev > > What did you not remove it? I figured it would be nicer for users if we waited until after a release. > Is there a reason or only an oversight? Do you mean why haven't I removed it after the 11.04 release? Because we haven't had a next release yet. > Is it the only thing to do? No, the property file also needs to be removed. > What about @Deprecated processEventReminder method? Do you mean processWorkEffortEventReminder? Because #1 it's a service so deprecating it would do nothing and #2 only a block needs to be removed so why deprecate it? > Should we keep EventReminders.properties file, etc. ? No the property file should also be removed, I don't know what else you're referring to with "etc." > > Jacques > > From: "Scott Gray" <[email protected]> >> The instructions seem quite clear to me. >> >> Regards >> Scott >> >> On 7/04/2012, at 10:09 PM, Jacques Le Roux wrote: >> >>> I meant this should awake a committer, at least one person should be aware >>> of that... >>> >>> Jacques >>> >>> From: "Jacques Le Roux" <[email protected]> >>>> Just look into *.java you will find it easily ;o) >>>> It's in WorkEffortServices.processWorkEffortEventReminder() >>>> Jacques >>>> From: "Pierre Smits" <[email protected]> >>>>> Hi Jacques, >>>>> This is very cryptic. To what issue does this relate to, and to what >>>>> application or component? >>>>> Regards, >>>>> Pierre >>>>> Op 7 april 2012 11:12 schreef Jacques Le Roux >>>>> <[email protected]>het volgende: >>>>>> Hi, >>>>>> >>>>>> Should we not remove this block and stuff related? >>>>>> // TODO: Remove this block after the next release 2010-11-29 >>>>>> >>>>>> Jacques >>>>>> >>>>> >>
