On 8/04/2012, at 11:05 PM, Jacques Le Roux wrote: > From: "Scott Gray" <[email protected]> >> Hi Jaques, >> >> All the answers are pretty obvious (to me at least) after a minute's look at >> the commit, but I'll humor you anyway. > > Thanks for the answer, with humour is better :o) > >> On 8/04/2012, at 10:08 PM, Jacques Le Roux wrote: >> >>> Hi Scott, >>> >>> So you committed this I see now >>> http://svn.apache.org/viewvc?rev=1040016&view=rev >>> >>> What did you not remove it? >> >> I figured it would be nicer for users if we waited until after a release. >> >>> Is there a reason or only an oversight? >> >> Do you mean why haven't I removed it after the 11.04 release? Because we >> haven't had a next release yet. > > Ha I did not understood that. I thought R11.04 was the next.
Sorry I mistyped the first sentence, I meant that 11.04 has been branched but not released. Code shouldn't be removed until after the actual release. > >>> Is it the only thing to do? >> >> No, the property file also needs to be removed. >> >>> What about @Deprecated processEventReminder method? >> >> Do you mean processWorkEffortEventReminder? Because #1 it's a service so >> deprecating it would do nothing and #2 only a block needs to be removed so >> why deprecate it? > > No I meant: should we not remove also the > WorkEffortServices.processEventReminder() deprecated method? Ah a different commit. After the official release all code deprecated prior to the 11.04 branch should be removed. >>> Should we keep EventReminders.properties file, etc. ? >> >> No the property file should also be removed, I don't know what else you're >> referring to with "etc." > > Unknown, so I put etc. , ... in case (was not so clear to me) > > So we will clear that with R12.04, right? Sorry I don't understand the question. > Jacques > >>> >>> Jacques >>> >>> From: "Scott Gray" <[email protected]> >>>> The instructions seem quite clear to me. >>>> >>>> Regards >>>> Scott >>>> >>>> On 7/04/2012, at 10:09 PM, Jacques Le Roux wrote: >>>> >>>>> I meant this should awake a committer, at least one person should be >>>>> aware of that... >>>>> >>>>> Jacques >>>>> >>>>> From: "Jacques Le Roux" <[email protected]> >>>>>> Just look into *.java you will find it easily ;o) >>>>>> It's in WorkEffortServices.processWorkEffortEventReminder() >>>>>> Jacques >>>>>> From: "Pierre Smits" <[email protected]> >>>>>>> Hi Jacques, >>>>>>> This is very cryptic. To what issue does this relate to, and to what >>>>>>> application or component? >>>>>>> Regards, >>>>>>> Pierre >>>>>>> Op 7 april 2012 11:12 schreef Jacques Le Roux >>>>>>> <[email protected]>het volgende: >>>>>>>> Hi, >>>>>>>> >>>>>>>> Should we not remove this block and stuff related? >>>>>>>> // TODO: Remove this block after the next release 2010-11-29 >>>>>>>> >>>>>>>> Jacques >>>>>>>> >>>>>>> >>>> >>
