On Feb 25, 2014, at 12:11 PM, Pierre Smits <[email protected]> wrote:

> As for OFBIZ-5319, this will be resolved when the patch provided in
> OFBiz-4130 has been committed.

I have tried to stay out of this because I am not particularly interested in 
the specific feature and I didn't want to be involved in a fight; however I see 
it is a long standing discussion and I would like to give it a try to resolve 
it.
Pierre, I see that your patch removes the configuration that assigns the 
Tenant* entities to the special org.ofbiz.tenant entity group; I have to admit 
that I don't fully understand the design that led to the creation of this 
group, but if we decide to get rid of it (as your patch implies) then we should 
also remove the check in GenericDelegator line 479:

        // to avoid infinite recursion, and to behave right for shared 
org.ofbiz.tenant entities, do nothing with the tenantId if the 
entityGroupName=org.ofbiz.tenant
        if (UtilValidate.isNotEmpty(this.delegatorTenantId) && 
!"org.ofbiz.tenant".equals(entityGroupName)) {

but before we do, I would like to understand the comment "to avoid infinite 
recursion, and to behave right for shared org.ofbiz.tenant entities...".
Pierre, have you been able to recreate the infinite recursion? under what 
conditions?

Jacopo


Reply via email to