Hi Hans, Two thoughts: 1. Are we sure we want to raise the barrier for any new potential major contributions? We don't receive so many as it is. Same thing with bug reports, would we ignore them if they don't have a test? Would we delay fixing the issue until someone feels like writing one? 2. IMO unit tests usually only provide value to prevent against regression. Obviously the tests would pass when committed and as such can't be used as a measure of the quality of a given contribution.
On the other hand, preventing regression is also a very important goal and existing unit tests are extremely useful when making changes in the code base. Writing unit tests is definitely something to be encouraged any way we can. Lastly, the majority of our tests are implemented in mini-lang and I'm really not a fan of it at all. If there were support for converting them to groovy (do we even support groovy tests?), I'd be glad to help lead that change. Regards Scott On 6/10/2014, at 2:49 pm, Hans Bakker <[email protected]> wrote: > Good morning, > > If you are following the relatively new developments in software development > you will be aware of continuous integration or the next step: continuous > deployment. This is all part of the 'continuous improvement' principle. > When the OFBiz system was initially implemented this was already recognized > that automated tests are required for a quality product. > > Therefore my proposal that: > 1. New functions must have automated tests in the same commit in order to be > considered for the trunk. > 2. Existing functions which are extended will need a JUnit test the same as > new functions. > 3. The introduction of a test framework for on-line screens which can run in > batched mode. > 4. Reporting of an error should be done by providing an automated test which > shows the error. > > You might want to read an article I wrote on this subject with at the end > links to the originators of this principle: > https://www.linkedin.com/pulse/article/20140909060033-1227556-upgrade-your-erp-system-like-a-phone-app > > So please let me know what you think? > > Regards,Hans >
