For the issue OFBIZ-5699, it was already in my mind to complete unit test ;)
In most case, add/improve/complete the unit test will be very beneficial
for the quality project. But set it as mandatory, I fear that will be a
contribution brake.
+1 for encourage it ! I'm sure some contributor want contribute but they
don't know what doing, and create unit test it's easier, formative and
helpful : so go on :) .
Nicolas
Le 06/10/2014 08:44, Hans Bakker a écrit :
Jacopo, I stand corrected! yes indeed the wrong Issue.
not 2699 but OFBIZ-4053, you are right.
Thank you and Scott for supporting the idea, so we get the quality of
OFBiz better.....
Left one open question to answer, how we are going to include user
interface tests.
Once we had selenium included, however it was removed....are there
alternatives?
Regards,'Hans
On 06/10/14 13:31, Jacopo Cappellato wrote:
A few days ago Scott and I had already discussed about unit tests for
the new query builder and they will come soon: the new API will not
go into any release without unit tests.
In fact I think that Scott told you that he is not going to work on
OFBIZ-5699 because he is busy with the query builder API at the
moment: but that ticket is completely unrelated to it and I am not
sure why you are asking him to work on it.
Jacopo
On Oct 6, 2014, at 8:14 AM, Hans Bakker
<[email protected]> wrote:
So Scott,
you introduce a new API named EntityQuery without a unit test, then
you are going to replace the existing well working API with
something which is not tested continuously....
i love the idea :-(
and then everybody asking for reliability and quality.....
Regards,
Hans
On 06/10/14 09:43, Scott Gray wrote:
On 6/10/2014, at 3:24 pm, Hans Bakker
<[email protected]> wrote:
On 06/10/14 09:15, Scott Gray wrote:
Hi Hans,
..........
Lastly, the majority of our tests are implemented in mini-lang
and I'm really not a fan of it at all. If there were support for
converting them to groovy (do we even support groovy tests?), I'd
be glad to help lead that change.
and then, start with OFBIZ-5699?
Regards,'Hans
That won't happen any time soon, I'll be dealing with the
conversion to EntityQuery for the foreseeable future.
Regards
Scott
