I personally think all the testing we need is in JUnit, Selenium and JMeter
for unit, integration and performance testing respectively. Unfortunately
we are firing selenium after and above OFBiz using gradle scripts.
Integration of Selenium into the framework is necessary in my opinion and
not only that but also into the core framework, not as a specialpurpose
component.

Unit tests are extremely useful and I do not mind at all to add them myself
while contributing anythying. However it is also difficult and requires
focused and deep thinking. So contributors should be mentored by senior
developers which is something not happening in here.

Raising the bar requires heavy mentoring, in all honesty i had to elbow my
way in and learned ofbiz the hard way. If a bug was submitted i usually had
to figure it out myself how to fix it. So in such atmosphere i'm not sure
if enforcing tests is the best option

Taher Alkhateeb.
On Oct 6, 2014 1:03 PM, "Jacopo Cappellato" <
[email protected]> wrote:

> Let's keep thinking and talking about how to improve our toolset for unit
> tests (and ui tests).I would also add to the mix load and performance tests.
> It is important that we do not only select the tools we consider important
> but also how we use them in OFBiz.
> I have also some ideas floating in my brain about how to unit test
> services but not ready to share it at the moment.
> But it is great to discuss about these things.
>
> Jacopo
>
> On Oct 6, 2014, at 8:44 AM, Hans Bakker <[email protected]>
> wrote:
>
> > Jacopo, I stand corrected! yes indeed the wrong Issue.
> >
> > not 2699 but OFBIZ-4053, you are right.
> >
> > Thank you and Scott for supporting  the idea, so we get the quality of
> OFBiz better.....
> >
> > Left one open question to answer, how we are going to include user
> interface tests.
> >
> > Once we had selenium included, however it was removed....are there
> alternatives?
> >
> > Regards,'Hans
> >
> >
> > On 06/10/14 13:31, Jacopo Cappellato wrote:
> >> A few days ago Scott and I had already discussed about unit tests for
> the new query builder and they will come soon: the new API will not go into
> any release without unit tests.
> >> In fact I think that Scott told you that he is not going to work on
> OFBIZ-5699 because he is busy with the query builder API at the moment: but
> that ticket is completely unrelated to it and I am not sure why you are
> asking him to work on it.
> >>
> >> Jacopo
> >>
> >> On Oct 6, 2014, at 8:14 AM, Hans Bakker <[email protected]>
> wrote:
> >>
> >>> So Scott,
> >>>
> >>> you introduce a new API named EntityQuery without a unit test, then
> you are going to replace the existing well working API with something which
> is not tested continuously....
> >>>
> >>> i love the idea :-(
> >>>
> >>> and then everybody asking for reliability and quality.....
> >>>
> >>> Regards,
> >>> Hans
> >>>
> >>> On 06/10/14 09:43, Scott Gray wrote:
> >>>> On 6/10/2014, at 3:24 pm, Hans Bakker <[email protected]>
> wrote:
> >>>>
> >>>>> On 06/10/14 09:15, Scott Gray wrote:
> >>>>>> Hi Hans,
> >>>>>> ..........
> >>>>>> Lastly, the majority of our tests are implemented in mini-lang and
> I'm really not a fan of it at all.  If there were support for converting
> them to groovy (do we even support groovy tests?), I'd be glad to help lead
> that change.
> >>>>>>
> >>>>>> and then, start with OFBIZ-5699?
> >>>>>>
> >>>>>> Regards,'Hans
> >>>> That won't happen any time soon, I'll be dealing with the conversion
> to EntityQuery for the foreseeable future.
> >>>>
> >>>> Regards
> >>>> Scott
> >
>
>

Reply via email to