Yeah I have no problem with removing it. But sometimes it's useful to know the history of where things came from. In this case I think it was thrown in quickly while I was working on database rollbacks within OFBiz itself, this was left over after that work was committed.
Regards Scott On 22 July 2016 at 01:32, Taher Alkhateeb <[email protected]> wrote: > Yeah that sounds about right. However here is why I suggest removing it: > > 1- it doesn't really have any logic it just spits out an Ant file or a text > file > 2- it goes through the server and comes out the other end as a build script > which makes it badly designed. either you do the whole thing inside the > server or the whole thing in the build system. it's really weird to have > that round-trip > 3- nobody used it for a long long time. in fact the first time I asked > about it no one recognized it even. It took me a while just to finally > understand what it does. > 4- our current tests do not require reset in between suites > 5- we removed Ant > 6- Before refactoring the start component it was not even documented. It > was just hidden as some flag that you don't know how to use with java -jar > ofbiz.jar -help (does not show up) > > So all in all it just seems like deadweight. hence my recommendation to > remove it > > Taher Alkhateeb > > On Thursday, 21 July 2016, Scott Gray <[email protected]> > wrote: > > > By the way, again my memory is hazy but I believe testlist was added as > > some sort of means to enable the database to be reverted to its original > > state between each set of tests. > > > > On 22 July 2016 at 01:21, Scott Gray <[email protected] > > <javascript:;>> wrote: > > > > > Why wouldn't it use the start up loader logic? What would it do > instead? > > > > > > On 22 July 2016 at 01:18, Taher Alkhateeb <[email protected] > > <javascript:;>> > > > wrote: > > > > > >> You got it right Scott. they load the both.properties and > pos.properties > > >> which in return contain the initializing classes to fire up POS. so > this > > >> is > > >> no different from say starting a mobile application which has nothing > to > > >> do > > >> with OFBiz from the start component. it should really start on its own > > >> without going through the start up loader logic > > >> > > >> On Thursday, 21 July 2016, Scott Gray <[email protected] > > <javascript:;>> > > >> wrote: > > >> > > >> > My memory is hazy, but don't those commands simply tell OFBiz which > > >> > [command].properties file to use for initialization? > > >> > > > >> > Regards > > >> > Scott > > >> > > > >> > On 21 July 2016 at 21:38, Taher Alkhateeb < > [email protected] > > <javascript:;> > > >> > <javascript:;>> > > >> > wrote: > > >> > > > >> > > Hello Everyone, > > >> > > > > >> > > This is a proposal to _remove_ the following commands from the > OFBiz > > >> > server > > >> > > (invoked with ./gradlew "ofbiz --commandHere" > > >> > > > > >> > > 1- --both > > >> > > 2- --pos > > >> > > 3- --testlist > > >> > > > > >> > > Reasons: > > >> > > - The POS component is a specialpurpose component and should not > > have > > >> > code > > >> > > existing in the start component. Instead logic for starting the > POS > > >> > > component should reside inside the POS component and away from > > >> framework > > >> > > - After lots of investigation I realized the testlist OFBiz > command > > >> is a > > >> > > weird command that used to create an ant file that just iterates > > over > > >> the > > >> > > existing integration test suites and run them one by one, which is > > >> slower > > >> > > vs just running them all. It is deprecated and to my knowledge no > > one > > >> is > > >> > > using it. I think it used to serve some deprecated cobertura > tasks. > > >> > > > > >> > > This would imply deleting the following files: > > >> > > - > > >> > > > > >> > > > > >> > > > >> > > > framework/start/src/main/java/org/apache/ofbiz/base/start/testlist.properties > > >> > > - > > >> > > > > >> > > > > >> > > > >> > > > framework/testtools/src/main/java/org/apache/ofbiz/testtools/TestListContainer.java > > >> > > - > > >> > > > > >> > > > >> > > > framework/base/src/main/java/org/apache/ofbiz/base/splash/SplashLoader.java > > >> > > > > >> > > and modifying the following files: > > >> > > - > > >> framework/start/src/main/java/org/apache/ofbiz/base/start/Config.java > > >> > > - > > >> > > > > >> > > > > >> > > > >> > > > framework/start/src/main/java/org/apache/ofbiz/base/start/StartupCommandUtil.java > > >> > > - (move it to POS) > > >> > > > > >> > > > >> > > > framework/base/src/main/java/org/apache/ofbiz/base/splash/SplashScreen.java > > >> > > > > >> > > Agreed? > > >> > > > > >> > > Regards, > > >> > > > > >> > > > >> > > > > > > > > >
