----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10199/#review19611 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/email/EmailSLAEventListener.java <https://reviews.apache.org/r/10199/#comment40516> yes, changed accordingly trunk/core/src/main/java/org/apache/oozie/email/EmailSLAEventListener.java <https://reviews.apache.org/r/10199/#comment40518> this is caught by caller method(onStartMiss/onEndMiss), which add error message, and die without sending email. trunk/core/src/main/java/org/apache/oozie/email/EmailSLAEventListener.java <https://reviews.apache.org/r/10199/#comment40519> thx, didn't know API supports actionID. removed if-blocks. trunk/core/src/main/java/org/apache/oozie/email/EmailSLAEventListener.java <https://reviews.apache.org/r/10199/#comment40520> Transport.send / Session are thread-safe. ok to share. also ErrorHandlerService processes event one by one sequentially. trunk/core/src/main/java/org/apache/oozie/email/EmailSLAEventListener.java <https://reviews.apache.org/r/10199/#comment40521> same with above. trunk/core/src/main/java/org/apache/oozie/email/EmailSLAEventListener.java <https://reviews.apache.org/r/10199/#comment40522> clean up is required, since deletion happens only when the same email stored in blacklist show up, and list might grow over time. but anyway, following Rohini's suggestion, use guava Cache(https://code.google.com/p/guava-libraries/wiki/CachesExplained), which automatically takes care of cleaning up, so no problem on this. - Ryota Egashira On April 18, 2013, 5:29 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10199/ > ----------------------------------------------------------- > > (Updated April 18, 2013, 5:29 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1294 > > > This addresses bug OOZIE-1294. > https://issues.apache.org/jira/browse/OOZIE-1294 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java > 1469083 > trunk/core/src/main/java/org/apache/oozie/email/EmailSLAEventListener.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/email/TestEmailSLAEventListener.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/10199/diff/ > > > Testing > ------- > > still WIP, especially error handling/test case > > > Thanks, > > Ryota Egashira > >
