----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10199/#review19527 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/email/EmailSLAEventListener.java <https://reviews.apache.org/r/10199/#comment40303> Threadlocal session trunk/core/src/main/java/org/apache/oozie/email/EmailSLAEventListener.java <https://reviews.apache.org/r/10199/#comment40305> If user configurable? trunk/core/src/main/java/org/apache/oozie/email/EmailSLAEventListener.java <https://reviews.apache.org/r/10199/#comment40304> use guava cache trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43322> use AtomicInteger trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43293> Define all the variables as public static constants in EmailActionExecutor and refer from there. trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43294> oozie.email. trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43295> oozie.email. TIMEOUT_DEFAULT COUNT_DEFAULT trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43296> oozie.email. trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43301> Add onDurationMiss also. And for each event, check the alert-events and don't send mail based on the configured value. If it is null, send alert-events to the values configured in oozie-site.xml. Load those values into a hashset in init() method for checking every time. trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43314> use getIfPresent and fetch once. And instead of contains do ==null check. trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43319> Remove the comment trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43321> Add Parent JobID trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43320> To be removed trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43323> Invalid addresses - have a separate cache and blacklist for a day. trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43324> Not sure why the format is like this. Haven't reviewed this class yet. - Rohini Palaniswamy On May 23, 2013, 8:40 a.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10199/ > ----------------------------------------------------------- > > (Updated May 23, 2013, 8:40 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1294 > > > This addresses bug OOZIE-1294. > https://issues.apache.org/jira/browse/OOZIE-1294 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java > 1485598 > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/10199/diff/ > > > Testing > ------- > > still WIP, especially error handling/test case > > > Thanks, > > Ryota Egashira > >
