----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10199/#review21044 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43537> Apache header trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43529> Rename it to CONF_ALERT_EVENTS and change the name of setting also in oozie-default.xml trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43530> Add "Oozie" and appname also in subject Oozie - SLA START_MISS (AppName=abc, JobID=xyz) trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43531> Can we change the order slightly with categorization headings (printHeading and printField). Status: \tSLA Status - \tJob Status - \tNotification Message - Job Details: \tApp Name \tApp Type \tJob ID \tJob URL \tParent Job ID (print only if not null) \tParent Job URL (if parent job is not null) \tUser \tUpstream Apps SLA Details: \tNominal Time \tExpected start \tActual start ... ... Actual duration Use the enum constructor (like EVENT_STATUS("SLA Status")) to pass the text that should appear in the message and use that while constructing the email message body. All Caps text in a mail might will make reading uncomfortable. trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43532> if (event.getParentId !== null) trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43533> getJobLink(jobID) - common method for both jobid and parent id trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43534> Needs to be getId after the JMS patch goes in trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43536> Apache header trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43538> Is variable substitution supported in notification message? - Rohini Palaniswamy On May 25, 2013, 8:13 a.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10199/ > ----------------------------------------------------------- > > (Updated May 25, 2013, 8:13 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1294 > > > This addresses bug OOZIE-1294. > https://issues.apache.org/jira/browse/OOZIE-1294 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java > 1486210 > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/10199/diff/ > > > Testing > ------- > > local test done > > > Thanks, > > Ryota Egashira > >
