----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10199/#review21096 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43837> Should not be doing this. For every get it is going to initialize automatically. trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43835> Annotation @VisibileForTesting. Keep it package private trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java <https://reviews.apache.org/r/10199/#comment43836> Do a explicit blackList.put() and remove initial load statement. - Rohini Palaniswamy On May 28, 2013, 7:52 a.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10199/ > ----------------------------------------------------------- > > (Updated May 28, 2013, 7:52 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1294 > > > This addresses bug OOZIE-1294. > https://issues.apache.org/jira/browse/OOZIE-1294 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java > 1486210 > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java > 1486210 > trunk/core/src/main/resources/oozie-default.xml 1486210 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/10199/diff/ > > > Testing > ------- > > local test done > > > Thanks, > > Ryota Egashira > >
