> On May 7, 2013, 2:31 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAStatusEventListener.java, > > line 65 > > <https://reviews.apache.org/r/10569/diff/4/?file=287578#file287578line65> > > > > Test does not add much value. Can add a unit test that queues a job > > event
this unit test meant to test only the SLAListener part. Another test file will be added for generating and queuing job events > On May 7, 2013, 2:31 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java, line 101 > > <https://reviews.apache.org/r/10569/diff/4/?file=287577#file287577line101> > > > > Status events only through EHS This unit test is only meant to test that Service works as expected. hence invoking service methods directly. TestSLAStatusEventListener indirectly checks status events being sent via EHS. And another test is being added for generating and queueing job events from XCommands - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10569/#review20260 ----------------------------------------------------------- On May 3, 2013, 10:09 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10569/ > ----------------------------------------------------------- > > (Updated May 3, 2013, 10:09 a.m.) > > > Review request for oozie. > > > Description > ------- > > 1. Revisiting the SLA handling in Oozie > 2. Addition of a calculator service to process sla events in a continuous > fashion > 3. Added new oozie-sla schema v0.2, concise and relevant > > > This addresses bug OOZIE-1244. > https://issues.apache.org/jira/browse/OOZIE-1244 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/AppType.java PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1478670 > trunk/client/src/main/java/org/apache/oozie/client/event/Event.java 1478670 > trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java > 1478670 > trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java > 1478670 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JSONMessageDeserializer.java > 1478670 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java > 1478670 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/CoordinatorActionMessage.java > 1478670 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/EventMessage.java > 1478670 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/JobMessage.java > 1478670 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/WorkflowJobMessage.java > 1478670 > trunk/client/src/main/resources/oozie-sla-0.2.xsd PRE-CREATION > trunk/core/pom.xml 1478670 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1478670 > trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1478670 > trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLAEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java 1478670 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java 1478670 > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLACalculationInsertUpdateJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLACalculatorGetJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventInsertJPAExecutor.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetJPAExecutor.java > 1478670 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryGetJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1478670 > trunk/core/src/main/java/org/apache/oozie/service/SchedulerService.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/service/SchemaService.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1478670 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorBean.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMem.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLAEventBean.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAJobEventListener.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1478670 > trunk/core/src/main/java/org/apache/oozie/util/SLAOperations.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java > 1478670 > trunk/core/src/main/java/org/apache/oozie/util/db/SLADbXOperations.java > 1478670 > trunk/core/src/main/resources/META-INF/oozie-derby-orm.xml 1478670 > trunk/core/src/main/resources/META-INF/oozie-hsqldb-orm.xml 1478670 > trunk/core/src/main/resources/META-INF/oozie-mysql-orm.xml 1478670 > trunk/core/src/main/resources/META-INF/oozie-postgresql-orm.xml 1478670 > trunk/core/src/main/resources/META-INF/persistence.xml 1478670 > trunk/core/src/main/resources/oozie-default.xml 1478670 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java > 1478670 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1478670 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 1478670 > trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java 1478670 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLACalculationJPAExecutor.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java > 1478670 > > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > 1478670 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAStatusEventListener.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1478670 > > Diff: https://reviews.apache.org/r/10569/diff/ > > > Testing > ------- > > ongoing > > > Thanks, > > Mona Chitnis > >
