----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10569/#review20384 -----------------------------------------------------------
You eclipse save action seems to be adding final to variables and changing import order. Will update comments on test cases in a short while. trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java <https://reviews.apache.org/r/10569/#comment41962> event status trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java <https://reviews.apache.org/r/10569/#comment41971> Turned on Eclipse save actions for adding final to variables by any chance? trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java <https://reviews.apache.org/r/10569/#comment41981> Can we remove the code in this patch instead of adding a TODO as it is wrong anyway and address it in the rerun jira. trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java <https://reviews.apache.org/r/10569/#comment42007> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java <https://reviews.apache.org/r/10569/#comment42004> Can this be put in XmlUtils as it is repeated lot trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java <https://reviews.apache.org/r/10569/#comment42009> Pass JobEventListener to the method and not iter. Same for sla trunk/core/src/main/java/org/apache/oozie/service/JPAService.java <https://reviews.apache.org/r/10569/#comment42010> Don't need fully qualified names trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java <https://reviews.apache.org/r/10569/#comment42011> Method name to addJobStatus, parameters to jobStatus and jobEventStatus trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java <https://reviews.apache.org/r/10569/#comment42025> Can remove Str from name. Why not enum herE? trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java <https://reviews.apache.org/r/10569/#comment42027> Make pacakage private and sdd anotation visiblefortesting trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLACalculationJPAExecutor.java <https://reviews.apache.org/r/10569/#comment42039> Tests to be moved under sla package trunk/client/src/main/resources/oozie-workflow-0.4.5.xsd <https://reviews.apache.org/r/10569/#comment41964> http://msdn.microsoft.com/en-us/library/ms256043.aspx http://www.w3schools.com/schema/el_any.asp namespace can be - List of {URI references of namespaces, ##targetNamespace, ##local} - elements from a space-delimited list of the namespaces can be present So we can put both 0.1 and 0.2 namespaces here separated by space and verify if that works. trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java <https://reviews.apache.org/r/10569/#comment41970> Can we use _ here also trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java <https://reviews.apache.org/r/10569/#comment41969> Constructor to the beginning of the class trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java <https://reviews.apache.org/r/10569/#comment41968> Can remove str from the name as another method already has Map in it. trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java <https://reviews.apache.org/r/10569/#comment42033> get and setSLARegistrationBean trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/10569/#comment42022> Why not queue directly on EventHandlerService and initialize it in constructor instead of getting SLAService in every method?. trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/10569/#comment42020> redundant trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/10569/#comment42012> sla status to running. Need to switch SLAStatus and EventStatus values. Eventstatus should be the events sent to listeners - start_miss, start_met, etc, and slastatus should be met, miss, running, not_started trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/10569/#comment42018> Remove from the map trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/10569/#comment42023> We should only alert if it took more time than expected duration and then failed. trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/10569/#comment42024> Remove from map trunk/core/src/main/java/org/apache/oozie/util/SLAXOperations.java <https://reviews.apache.org/r/10569/#comment42030> Wouldn't the user specify in mins? trunk/core/src/main/java/org/apache/oozie/util/SLAXOperations.java <https://reviews.apache.org/r/10569/#comment42028> Wouldn't the user specify in mins? trunk/core/src/main/java/org/apache/oozie/util/SLAXOperations.java <https://reviews.apache.org/r/10569/#comment42032> Do not set the alert types if not specified. Leave the Email SLA listener to read the setting and act based on that. Or read it in SLAService or SLACalculatorMemory on init() and not queue the event. Persisting on the DB when null will make it binding even if config is changed and system restarted. trunk/core/src/main/resources/META-INF/oozie-postgresql-orm.xml <https://reviews.apache.org/r/10569/#comment42034> To be removed trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java <https://reviews.apache.org/r/10569/#comment42037> This file needs to be reverted - Rohini Palaniswamy On May 9, 2013, 5:45 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10569/ > ----------------------------------------------------------- > > (Updated May 9, 2013, 5:45 p.m.) > > > Review request for oozie. > > > Description > ------- > > 1. Revisiting the SLA handling in Oozie > 2. Addition of a calculator service to process sla events in a continuous > fashion > 3. Added new oozie-sla schema v0.2, concise and relevant > > > This addresses bug OOZIE-1244. > https://issues.apache.org/jira/browse/OOZIE-1244 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/AppType.java PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java > 1480726 > trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1480726 > trunk/client/src/main/java/org/apache/oozie/client/event/Event.java 1480726 > trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java > 1480726 > trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java > 1480726 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JSONMessageDeserializer.java > 1480726 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java > 1480726 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/CoordinatorActionMessage.java > 1480726 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/EventMessage.java > 1480726 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/JobMessage.java > 1480726 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/WorkflowJobMessage.java > 1480726 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java > 1480726 > trunk/client/src/main/resources/oozie-sla-0.2.xsd PRE-CREATION > trunk/client/src/main/resources/oozie-workflow-0.4.5.xsd 1480726 > trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java > 1480726 > trunk/core/pom.xml 1480726 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1480726 > trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1480726 > trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java 1480726 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java 1480726 > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventInsertJPAExecutor.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetJPAExecutor.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculationInsertUpdateJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculatorGetJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1480726 > trunk/core/src/main/java/org/apache/oozie/service/SchedulerService.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/service/SchemaService.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1480726 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorBean.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAJobEventListener.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1480726 > trunk/core/src/main/java/org/apache/oozie/util/SLAOperations.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/util/SLAXOperations.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/util/db/SLADbXOperations.java > 1480726 > trunk/core/src/main/resources/META-INF/oozie-postgresql-orm.xml 1480726 > trunk/core/src/main/resources/META-INF/persistence.xml 1480726 > trunk/core/src/main/resources/oozie-default.xml 1480726 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java > 1480726 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java > 1480726 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1480726 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 1480726 > trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java 1480726 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLACalculationJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java > 1480726 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java > 1480726 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationGetJPAExecutor.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java > 1480726 > > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > 1480726 > trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java > 1480726 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1480726 > trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1480726 > trunk/core/src/test/resources/coord-action-sla.xml PRE-CREATION > trunk/core/src/test/resources/wf-action-sla.xml PRE-CREATION > trunk/core/src/test/resources/wf-job-sla.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/10569/diff/ > > > Testing > ------- > > ongoing > > > Thanks, > > Mona Chitnis > >
