> On May 13, 2013, 7:55 a.m., Virag Kothari wrote: > > trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java, > > line 184 > > <https://reviews.apache.org/r/10569/diff/5/?file=289592#file289592line184> > > > > what is being stored in job-data?
It is to store any type of detailed information e.g. bundle-id, coord-id, etc for power-users. Will be populated later, but schema should be finalized now. > On May 13, 2013, 7:55 a.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java, > > line 219 > > <https://reviews.apache.org/r/10569/diff/5/?file=289621#file289621line219> > > > > Remove this if generating events for wf action is not part of this patch decided to be part of same patch as it is overkill work to separate it out > On May 13, 2013, 7:55 a.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java, > > line 58 > > <https://reviews.apache.org/r/10569/diff/5/?file=289646#file289646line58> > > > > Instead of combining two JPA queries, better to have separate JPA > > executors as one returns list while other returns a single record removed the bulk query altogether. Don't think we'd ever require to fetch ALL records from Summary table > On May 13, 2013, 7:55 a.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, > > line 115 > > <https://reviews.apache.org/r/10569/diff/5/?file=289658#file289658line115> > > > > why should expected start be considered for duration miss? <duration> tag is optional, so default expected duration is expected End - expected start. Now during periodic calculation, if job not started yet, duration so far can be counted as current time - expected start > On May 13, 2013, 7:55 a.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, > > line 132 > > <https://reviews.apache.org/r/10569/diff/5/?file=289658#file289658line132> > > > > can we move this line to common block in the if (change) block? different events need to be queued per type i.e. start/end/duration miss > On May 13, 2013, 7:55 a.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, > > line 156 > > <https://reviews.apache.org/r/10569/diff/5/?file=289658#file289658line156> > > > > Instead of creating the slaCalcStatus with the entire registration > > bean, can we create it with only the required fields. different jira > On May 13, 2013, 7:55 a.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, > > line 200 > > <https://reviews.apache.org/r/10569/diff/5/?file=289658#file289658line200> > > > > Suspend and failed shouldn't be handled in same way. Suspended jobs > > should be ignored for SLA's umm..dont think suspended jobs should be ignored. Jobs can be suspended owing to some system level malfunction/restart. Currently no way to differentiate between that and user-initiated suspend. But can be handled a little differently yes.. will do in next patch > On May 13, 2013, 7:55 a.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java, > > line 167 > > <https://reviews.apache.org/r/10569/diff/5/?file=289659#file289659line167> > > > > where is this method used? removed > On May 13, 2013, 7:55 a.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAJobEventListener.java, > > line 72 > > <https://reviews.apache.org/r/10569/diff/5/?file=289662#file289662line72> > > > > I think we should filter suspend ones too for sla same comment as above. > On May 13, 2013, 7:55 a.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/util/SLAXOperations.java, line 66 > > <https://reviews.apache.org/r/10569/diff/5/?file=289666#file289666line66> > > > > if converting from float to long, why use float? > > same for expectedduration and expectedend This takes care of floating point figures e.g. 5.5 * MINUTES in the SLA shoud-start, should-end and duration tags. Multiplying float later with 60,000 still gives float and hence the cast to long else compilation error when adding to Date.getTime() - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10569/#review20469 ----------------------------------------------------------- On May 9, 2013, 5:45 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10569/ > ----------------------------------------------------------- > > (Updated May 9, 2013, 5:45 p.m.) > > > Review request for oozie. > > > Description > ------- > > 1. Revisiting the SLA handling in Oozie > 2. Addition of a calculator service to process sla events in a continuous > fashion > 3. Added new oozie-sla schema v0.2, concise and relevant > > > This addresses bug OOZIE-1244. > https://issues.apache.org/jira/browse/OOZIE-1244 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/AppType.java PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java > 1480726 > trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1480726 > trunk/client/src/main/java/org/apache/oozie/client/event/Event.java 1480726 > trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java > 1480726 > trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java > 1480726 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JSONMessageDeserializer.java > 1480726 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java > 1480726 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/CoordinatorActionMessage.java > 1480726 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/EventMessage.java > 1480726 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/JobMessage.java > 1480726 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/WorkflowJobMessage.java > 1480726 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java > 1480726 > trunk/client/src/main/resources/oozie-sla-0.2.xsd PRE-CREATION > trunk/client/src/main/resources/oozie-workflow-0.4.5.xsd 1480726 > trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java > 1480726 > trunk/core/pom.xml 1480726 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1480726 > trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1480726 > trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java 1480726 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java 1480726 > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventInsertJPAExecutor.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetJPAExecutor.java > 1480726 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculationInsertUpdateJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculatorGetJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1480726 > trunk/core/src/main/java/org/apache/oozie/service/SchedulerService.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/service/SchemaService.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1480726 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorBean.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAJobEventListener.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1480726 > trunk/core/src/main/java/org/apache/oozie/util/SLAOperations.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/util/SLAXOperations.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java > 1480726 > trunk/core/src/main/java/org/apache/oozie/util/db/SLADbXOperations.java > 1480726 > trunk/core/src/main/resources/META-INF/oozie-postgresql-orm.xml 1480726 > trunk/core/src/main/resources/META-INF/persistence.xml 1480726 > trunk/core/src/main/resources/oozie-default.xml 1480726 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java > 1480726 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java > 1480726 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1480726 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 1480726 > trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java 1480726 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLACalculationJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java > 1480726 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java > 1480726 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationGetJPAExecutor.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java > 1480726 > > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > 1480726 > trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java > 1480726 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1480726 > trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1480726 > trunk/core/src/test/resources/coord-action-sla.xml PRE-CREATION > trunk/core/src/test/resources/wf-action-sla.xml PRE-CREATION > trunk/core/src/test/resources/wf-job-sla.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/10569/diff/ > > > Testing > ------- > > ongoing > > > Thanks, > > Mona Chitnis > >
