----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11294/#review20922 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11294/#comment43101> Why nested if? Can do AND trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11294/#comment43102> Need to set setEventProcessed trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11294/#comment43103> Need to set setEventProcessed trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11294/#comment43104> Need to set setEventProcessed trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11294/#comment43106> Need to set setEventProcessed trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11294/#comment43105> Need to set setEventProcessed trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java <https://reviews.apache.org/r/11294/#comment43107> Can you change this also to byte as discussed for different sla processing states? - Rohini Palaniswamy On May 21, 2013, 2:16 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11294/ > ----------------------------------------------------------- > > (Updated May 21, 2013, 2:16 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1361 > > > This addresses bug OOZIE-1361. > https://issues.apache.org/jira/browse/OOZIE-1361 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculatorGetJPAExecutor.java > 1484558 > trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1484558 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 1484558 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorBean.java > 1484558 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 1484558 > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1484558 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java > 1484558 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1484558 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > 1484558 > trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1484558 > > Diff: https://reviews.apache.org/r/11294/diff/ > > > Testing > ------- > > modified the unit test to reflect patch changes > > > Thanks, > > Mona Chitnis > >
