> On May 22, 2013, 11:35 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java, line 101 > > <https://reviews.apache.org/r/11294/diff/1/?file=295129#file295129line101> > > > > Can you change this also to byte as discussed for different sla > > processing states?
done. setting of slaProcessed appropriately at different junctures is added > On May 22, 2013, 11:35 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, > > lines 109-110 > > <https://reviews.apache.org/r/11294/diff/1/?file=295128#file295128line109> > > > > Why nested if? Can do AND ok > On May 22, 2013, 11:35 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, > > line 286 > > <https://reviews.apache.org/r/11294/diff/1/?file=295128#file295128line286> > > > > Need to set setEventProcessed all the setting eventProcessed is done at a central place in the addJobStatus method itself as it is common for all status cases. - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11294/#review20922 ----------------------------------------------------------- On May 21, 2013, 2:16 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11294/ > ----------------------------------------------------------- > > (Updated May 21, 2013, 2:16 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1361 > > > This addresses bug OOZIE-1361. > https://issues.apache.org/jira/browse/OOZIE-1361 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculatorGetJPAExecutor.java > 1484558 > trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1484558 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 1484558 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorBean.java > 1484558 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 1484558 > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1484558 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java > 1484558 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1484558 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > 1484558 > trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1484558 > > Diff: https://reviews.apache.org/r/11294/diff/ > > > Testing > ------- > > modified the unit test to reflect patch changes > > > Thanks, > > Mona Chitnis > >
