----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11294/#review20959 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java <https://reviews.apache.org/r/11294/#comment43274> Initialize to -1 trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java <https://reviews.apache.org/r/11294/#comment43269> Add javadoc saying what 0,1 and 2 stand for. trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11294/#comment43330> Need to handle case where end is processed but duration is not. Use a Linux rwx - 421 style to calculate it. trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java <https://reviews.apache.org/r/11294/#comment43265> Index here also trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java <https://reviews.apache.org/r/11294/#comment43331> Index here trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java <https://reviews.apache.org/r/11294/#comment43275> Initialize to -1 - Rohini Palaniswamy On May 23, 2013, 8:17 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11294/ > ----------------------------------------------------------- > > (Updated May 23, 2013, 8:17 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1361 > > > This addresses bug OOZIE-1361. > https://issues.apache.org/jira/browse/OOZIE-1361 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java > 1485782 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculatorGetJPAExecutor.java > 1485782 > trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1485782 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 1485782 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorBean.java > 1485782 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 1485782 > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1485782 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java > 1485782 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1485782 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > 1485782 > trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1485782 > > Diff: https://reviews.apache.org/r/11294/diff/ > > > Testing > ------- > > modified the unit test to reflect patch changes > > > Thanks, > > Mona Chitnis > >
