----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11294/#review20992 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11294/#comment43402> Need a nested if here to set eventProcessed++ in case expectedstart is null trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11294/#comment43401> Use bitshift check to test if the second bit is set. Also mention in a comment.. ((eventProcessed >>2) & 1) == 0; it will be a single check and fast. trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11294/#comment43403> Shouldn't it be +6 - Rohini Palaniswamy On May 24, 2013, 7:51 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11294/ > ----------------------------------------------------------- > > (Updated May 24, 2013, 7:51 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1361 > > > This addresses bug OOZIE-1361. > https://issues.apache.org/jira/browse/OOZIE-1361 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java > 1485857 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculatorGetJPAExecutor.java > 1485857 > trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1485857 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 1485857 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorBean.java > 1485857 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 1485857 > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1485857 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java > 1485857 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1485857 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > 1485857 > trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1485857 > trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 1485857 > > Diff: https://reviews.apache.org/r/11294/diff/ > > > Testing > ------- > > modified the unit test to reflect patch changes > > > Thanks, > > Mona Chitnis > >
