> On May 28, 2013, 4:07 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java, > > lines 118-119 > > <https://reviews.apache.org/r/10199/diff/8/?file=297119#file297119line118> > > > > Should not be doing this. For every get it is going to initialize > > automatically. > > Ryota Egashira wrote: > my understanding is that this load function is only called when key > doesn't exist for get call, so should be fine, but I can double-check in test > case. > > Rohini Palaniswamy wrote: > Looks like that is how it works. We should be good since we are using > getIfPresent call. Else it would create one entry for each email address. Can > you put a warning comment near getIfPresent saying "Do not change to get() > call here as it will load into the cache".
hmm, even for get(), seem the same based on doc. http://code.google.com/p/guava-libraries/wiki/CachesExplained "The canonical way to query a LoadingCache is with the method get(K). This will either return an already cached value, or else use the cache's CacheLoader to atomically load a new value into the cache." - Ryota ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10199/#review21096 ----------------------------------------------------------- On May 28, 2013, 7:52 a.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10199/ > ----------------------------------------------------------- > > (Updated May 28, 2013, 7:52 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1294 > > > This addresses bug OOZIE-1294. > https://issues.apache.org/jira/browse/OOZIE-1294 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java > 1486210 > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java > 1486210 > trunk/core/src/main/resources/oozie-default.xml 1486210 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/10199/diff/ > > > Testing > ------- > > local test done > > > Thanks, > > Ryota Egashira > >
