-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11797/#review21712
-----------------------------------------------------------



trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/11797/#comment44875>

    You need to check against database when you are looping through and 
checking periodically. Not when you receive a job success or failure event. The 
event is the confirmation.
    
     Also check only if the job has not completed (end_miss)


- Rohini Palaniswamy


On June 11, 2013, 4:24 a.m., Mona Chitnis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11797/
> -----------------------------------------------------------
> 
> (Updated June 11, 2013, 4:24 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1379
> 
> 
> This addresses bug OOZIE-1379.
>     https://issues.apache.org/jira/browse/OOZIE-1379
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 
> 1491669 
>   trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1491669 
> 
> Diff: https://reviews.apache.org/r/11797/diff/
> 
> 
> Testing
> -------
> 
> added unit test
> 
> 
> Thanks,
> 
> Mona Chitnis
> 
>

Reply via email to